Test make pgtle PGTLE_VERSION=X limiting output - #32
Merged
jnasbyupgrade merged 3 commits intoJul 26, 2026
Merged
Conversation
Add tests/updates for pgxntool commit a3c0b02 (fix `make pgtle PGTLE_VERSION=X` being ignored): - base.mk's pgtle target now forwards PGTLE_VERSION through to pgtle.sh's --pgtle-version flag instead of silently ignoring it Add a BATS test in test/sequential/04-pgtle.bats asserting that `make pgtle PGTLE_VERSION=1.5.0+` generates only the requested version range's output file, and clarify the neighboring test's stale comment now that the Makefile path is also covered. Co-Authored-By: Claude <[email protected]>
s/specific/specified/ — "specified version" more clearly refers to the version passed via PGTLE_VERSION=X, per review feedback on PR Postgres-Extensions#32. Co-Authored-By: Claude <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 26, 2026 21:06
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Jul 26, 2026
`base.mk`'s `pgtle` target never forwarded the `PGTLE_VERSION` make variable to `pgtle.sh --pgtle-version`, so `make pgtle PGTLE_VERSION=1.5.0+` silently generated all three version ranges instead of the one requested — despite this being the documented usage Companion pgxntool-test PR: Postgres-Extensions/pgxntool-test#32 Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make pgtle PGTLE_VERSION=Xbeing silently ignored (issue pgxntool#65).test/sequential/04-pgtle.batsassertingmake pgtle PGTLE_VERSION=1.5.0+generates only the requested version range's output file, not all three.pgtlebefore pulling in the fix.