Repository navigation
docs(mcp-analytics): forbid the standalone $identify event - #134
Merged
Merged
Conversation
The JS and Python SDKs no longer send $identify from MCP servers. It carried no $anon_distinct_id, so it merged no person, and every event already carries distinct_id, $set and $groups. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
gesh
marked this pull request as ready for review
October 19, 2026 14:44
gesh
requested review from
a team and
lucasheriques
and removed request for
a team
October 19, 2026 14:44
dustinbyrne
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
$identify, and the JS and Python SDKs no longer do.$anon_distinct_id, so ingestion merges no person from it.distinct_id,$setand$groups.Changes
$identify, for any MCP revision or session mode.$setand$groupson identified events,$process_person_profile: falseon anonymous ones.$identify.acceptance/public/mcp-analytics.featurenow asserts no$identify. It reuses the harness phraseno event named "…" should be enqueued.openspec/changes/archive/2026-10-19-drop-mcp-identify-event/.Note
Insights built on
$identifyfrom MCP servers stop receiving that event. Person properties are unaffected.Testing
openspec validate --specs --strict --no-interactivewith CI's pinned 1.4.1 passes all 64 specs.🤖 Agent context
claude-opus-5-5.writing-pr-descriptions.🤖 Generated with Claude Code