Repository navigation
fix(clickhouse): retire the native events pool when its host changes - #120295
vdekrijger wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
🤖 CI report
|
|
Superseded by #122489, which merged on Oct 26 and routes events_json reads to the events cluster with one rule instead of the per-query opt-in this PR carried. Closing; the branch stays. |
Problem
Staff can change the native events cluster host at runtime through an instance setting. Each host change caches one more ClickHouse connection pool per worker, and the old pools keep their sockets open indefinitely.
Changes
How did you test this code?
Test rationale:
test_native_events_pool_is_retired_when_the_host_changesin the existing connection tests switches the host, checks that a new pool serves it, and checks that a client returned to the old pool disconnects.Release status
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted).
Agent: Claude Code, model
claude-opus-5-5.Split out of #116838 so each piece of the native events cluster rollout reviews on its own. Skills: stacking-prs, writing-tests, writing-code-comments, writing-pr-descriptions.