[thiagosalvatore]

Problem

• Warehouse suggestions have an API but no UI, so nobody sees them.
• This adds the two surfaces the design review chose: the views tab on /models and the certifications tab in the data catalog.

Changes

Behind the warehouse-suggestions flag:

• Models tab: one slim, orange-tinted banner above the views table: "4 views could save ~2 hours of query time and 2.73 TB of scanning a month", with the totals in green and a "Review 4" button.
  • Review opens a dialog with one row per view: the saving in one aligned column, reads and people, and the data age after materializing.
  • Unmaterialize suggestions are in the same list. Their row shows the saving (the refresh cost minus the estimated cost of computing the view on each read) and how long one read takes. "Stop materializing" opens a dialog with the refresh cost now, the estimated cost when computed on read, and the saving.
  • Hovering or focusing "214 reads · 6 people" shows reads by surface as a bar, days read, and the query-log caveat.
  • Rows are sorted by what they save, time savers first.
• Catalog: the same banner ("3 certification suggestions: 2 to certify · 1 to mark deprecated") above the filters, and the same dialog with Certify or Mark deprecated and Dismiss. Deprecate rows say "No reads recorded in 30 days" and carry the caveat.
  • Accepting a deprecate for a view now also stops its refreshes and deletes its stored table by default. The backend does this only when the view still materializes and no other view, sync, direct source or reader access depends on it, checked again at accept time.
  • So Mark deprecated on a view opens a dialog with "Stop refreshing it" (the default) and "Keep refreshing it". Keep sends keep_materialized: true, so a person can deprecate a view and keep it materialized. A table deprecation stays one click.
  • The toast reads created_asset.stopped_materialization: "…and stopped its refreshes" when it did, otherwise "Marked X as deprecated."
• Materialize dialog: the data age follows the picked schedule, and the saving is labeled as an estimate at the suggested settings.
  • The hint under the schedule gives the backend's reason for the suggested interval (refresh_interval_basis): sources sync no faster, people read no more often, it is the fastest schedule, or it is the shortest one that saves more than it costs. A shorter pick shows a warning with the same reason.
  • A "Refresh mode" section reuses IncrementalConfigOptions from the SQL editor, starting from the proposed mode, key, unique key and lookback. It runs check_incremental on the view's query to list the key candidates.
  • Materialize sends refresh_interval_seconds plus only the refresh options that differ from the proposal, so an unchanged suggestion is accepted as proposed.
  • When the backend refuses any of these options, the dialog stays open and shows its message.
• Incremental proposals say "Incremental by <key>" in the row.
• After an action: the row collapses out over 150 ms, and the toast offers Undo (dismiss) or View (accept). View opens the view in the SQL editor after a materialize or unmaterialize.
• A 409 on accept shows the backend's reason, such as a query that changed since the suggestion or another view that now reads it. The confirm dialog closes and the list reloads.
  • Undo calls the existing resume endpoint, so a dismiss is never delayed and closing the tab never loses it.
  • View closes the dialog. On the catalog it then clears the filters, opens the page that holds the new certification, highlights it and scrolls to it.
  • The last handled row shows "All caught up" in the dialog. The banner goes away once nothing is left.
• Data age is qualified when a source has no sync schedule. A live view still reads "Data up to 1 day old" once materialized daily.
• Keyboard focus moves to the next row's main action after a row leaves, then to the section header.
• Rows and banners use the colored product icons from the sidebar: Models for views, Data warehouse for tables, Data catalog on the catalog banner.
• Error, warming-up and not-eligible states each have their own one-line notice.
• New events: warehouse suggestion review opened (banner to dialog), and warehouse suggestion confirm opened and warehouse suggestion confirm cancelled for the deprecate and stop-materializing dialogs.
• The dialog computes data age with the backend's formula from backend/logic/candidates/materialize.py (interval plus today's source age). If the backend changes it, dataAgeLabel needs the same change.
• Mechanical: merges of master (typed evidence and no score, the refresh mode and accept overrides, then the deprecate stop and the unmaterialize kind from feat(warehouse-suggestions): stop refreshes when accepting a deprecate #121459 and feat(warehouse-suggestions): suggest unmaterializing rarely read views #121460), and lockfile syncs of this package's importer to master's catalog versions.

How did you test this code?

Test rationale:

• warehouseSuggestionsLogic.test.ts, extended. Each new case guards one regression:
  • rows out of order;
  • a bytes saver counted toward the time total;
  • a leaving row still counted, or the section unmounting while the last row leaves;
  • a failed dismiss hidden later by its own leave timer (mutation-checked);
  • a second same-reason toast deduped away with its Undo;
  • Undo failing after a reload, or restoring a row whose resume failed;
  • View going to the wrong place, leaving the dialog open over the table, or offered with no certification id;
  • the schedule warning firing on equal or longer picks;
  • the dialog closing when the backend refuses any refresh option;
  • Materialize sending unchanged proposal options, or dropping the keys when a person switches between full and incremental;
  • the incremental check not running when the dialog opens;
  • an unmaterialize row missing from the models list or sorted by the wrong saving;
  • "Keep refreshing" not sent, or sent inverted, and a toast that misreports whether refreshes stopped;
  • a 409 on accept hiding the backend's reason, or leaving the confirm dialog open;
  • View after an unmaterialize going anywhere but the SQL editor.
• suggestionCopy.test.ts (new): data age for known, live and unscheduled sources, and a hint for each interval reason.
• certificationsLogic.test.ts: View for a row on page 2 opens page 2 of the certifications table, with the filters and sort cleared.
• Storybook: the banner, the review dialog and the state notices on both surfaces, rendered headless at 1000 px and 520 px. The incremental and longer-schedule dialogs were rendered after the refresh-mode change. The deprecate and stop-materializing dialogs and the mixed review list were rendered at 1300 px and 520 px.
• Local app on a private database, driven headless before the banner change: dismiss then Undo (server dismissed, then proposed), the schedule warning, certify then View with a filter on, and the last row from the keyboard. The rows and actions are unchanged since; the banner and review dialog were checked in Storybook only.
• Not run: a deprecate or unmaterialize accept against a real backend. The logic tests cover the request bodies and toasts with a mocked API.
• Not run: a successful materialize. The local stack has no materialization backend, so accept hit the existing error path: an error toast, the dialog stays open, the row stays.

Release status

• This change is behind a feature flag and is not available to users

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5

• The first version showed suggestions as prose cards in a grey panel; a design review replaced it with a collapsible section of rows. That section still took too much space, so it became the banner and dialog after comparing three mockups (banner, inline table tags, compact cards). Earlier screenshots in this description were replaced each time.
• /plan-design-review (20 decisions) and /plan-eng-review (4 decisions, plus a Codex outside voice) shaped the plan. The eng review found the resume endpoint, so Undo needs no delayed send, and the outside voice found the toast dedupe and the last-row unmount.
• Skills invoked: /writing-ui-components, /writing-user-facing-copy, /writing-tests, /using-kea-disposables, /browse, /plan-design-review, /plan-eng-review, /writing-pr-descriptions.
• Left out: the paused state, re-expanding on a new batch, and loading a view's allowed schedules into the picker.

🤖 Generated with Claude Code

[github-actions]

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

⚠️ Complexity (TypeScript) — 5 functions above the limit (max 53)

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

Function	Location	Complexity	Limit
describerFor	frontend/src/lib/components/ActivityLog/describers.tsx:56	53	10
CertificationSuggestionRow	products/warehouse_suggestions/frontend/components/CertificationSuggestionRow.tsx:27	14	10
MaterializeSuggestionModal	products/warehouse_suggestions/frontend/components/MaterializeSuggestionModal.tsx:25	14	10
changedRefreshOptions	products/warehouse_suggestions/frontend/warehouseSuggestionsLogic.ts:126	12	10
<anonymous>	products/warehouse_suggestions/frontend/warehouseSuggestionsLogic.ts:651	11	10

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

⚠️ Duplication (TypeScript) — 1 new duplicated block (worst 138 tokens)

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

First copy	Second copy	Lines	Tokens
products/warehouse_suggestions/frontend/components/MaterializeSuggestionRow.tsx:31	products/warehouse_suggestions/frontend/components/UnmaterializeSuggestionRow.tsx:36	32	138

⚠️ Bundle size — 🔺 +16.9 KiB (+0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 76.17 MiB · 🔺 +16.9 KiB (+0.0%)

File	Size	Δ vs base
posthog-app/_parent/products/data_modeling/frontend/ModelsScene.js	83.6 KiB	🔺 +9.8 KiB (+13.3%)
posthog-app/_parent/products/data_catalog/frontend/DataCatalogScene.js	38.6 KiB	🔺 +5.1 KiB (+15.1%)

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root	Eager (shipped)	Δ vs base	Budget
entry (logged-out pages, app bootstrap) src/index.tsx	1017.3 KiB · 24 files	🔺 +933 B (+0.1%)	█████████░ 86.8% of 1.14 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login) src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts	2.92 MiB · 620 files	🔺 +1.0 KiB (+0.0%)	██████████ 96.2% of 3.03 MiB
authenticated shell (every logged-in page) src/scenes/AuthenticatedShell.tsx	7.28 MiB · 2,543 files	🔺 +1.2 KiB (+0.0%)	██████████ 97.2% of 7.50 MiB
dashboard scene src/scenes/dashboard/Dashboard.tsx	9.67 MiB · 3,706 files	🔺 +1.3 KiB (+0.0%)	██████████ 96.5% of 10.01 MiB
today home path src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx	7.45 MiB · 2,635 files	🔺 +1.2 KiB (+0.0%)	██████████ 96.3% of 7.74 MiB
AI-first home path src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx	7.53 MiB · 2,616 files	🔺 +1.2 KiB (+0.0%)	████████░░ 84.0% of 8.96 MiB
events scene src/scenes/activity/explore/EventsScene.tsx	9.14 MiB · 3,497 files	🔺 +1.2 KiB (+0.0%)	██████████ 95.3% of 9.59 MiB
web analytics scene src/scenes/web-analytics/WebAnalyticsScene.tsx	10.00 MiB · 3,715 files	🔺 +1.2 KiB (+0.0%)	█████████░ 92.3% of 10.83 MiB
replay detail scene src/scenes/session-recordings/detail/SessionRecordingDetail.tsx	8.21 MiB · 3,077 files	🔺 +1.2 KiB (+0.0%)	█████████░ 86.7% of 9.47 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/zod/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/billing/billingLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/ProductEmptyState/productSetupPreloadLogic.ts stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/dashboards/frontend/widgets/previews/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/wizard/frontend/runs/WizardRunDetailsDrawer.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayShell.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayContextPanelFloating.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodaySidePanel.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayTopBar.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/todayRailItems.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 zod/v4/locales/de.js stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/validators.js stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 packages/quill/packages/charts/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/VisualizationWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/RecordingsWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/api/primitives.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/scenes/notebooks/Notebook/notebookLogic.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/validators.js stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 products/product_analytics/frontend/insights/trends/WorldMap/countryVectors.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/scenes/settings/SettingsMap.tsx stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 @jspm/core/nodelibs/browser/fs stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Largest files eagerly shipped from src/index.tsx

Size	File
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB	../node_modules/.pnpm/[email protected]/node_modules/buffer/index.js
6.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/react/cjs/react.production.min.js
4.5 KiB	../node_modules/.pnpm/@[email protected]/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB	../node_modules/.pnpm/[email protected]/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB	../node_modules/.pnpm/[email protected]/node_modules/base64-js/index.js
1.4 KiB	src/index.tsx
1.3 KiB	src/RootErrorBoundary.tsx
1.3 KiB	src/lib/utils/bootTiming.ts
912 B	../node_modules/.pnpm/[email protected]/node_modules/ieee754/index.js

Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
69.4 KiB	src/lib/lemon-ui/icons/icons.tsx
38.7 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@dnd-kit/core/dist/core.esm.js
33.9 KiB	../node_modules/.pnpm/[email protected]_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
29.4 KiB	src/scenes/scenes.ts
27.2 KiB	src/lib/constants.tsx

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
93.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js
90.6 KiB	../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js

Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
143.2 KiB	../packages/quill/packages/primitives/dist/index.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
93.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
93.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js
90.6 KiB	../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
93.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js
90.6 KiB	../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js

Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
143.2 KiB	../packages/quill/packages/primitives/dist/index.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
93.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js

Largest files eagerly shipped from src/scenes/web-analytics/WebAnalyticsScene.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
183.2 KiB	src/queries/validators.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
143.2 KiB	../packages/quill/packages/primitives/dist/index.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts

Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Size	File
322.5 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs
316.1 KiB	../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/rrweb.js
286.8 KiB	src/taxonomy/core-filter-definitions-by-group.json
238.5 KiB	../packages/quill/packages/quill/dist/index.js
220.9 KiB	../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB	../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js
126.8 KiB	../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js
106.3 KiB	src/products.tsx
98.9 KiB	src/lib/api.ts
93.3 KiB	../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

✅ Toolbar bundle — eager 2.29 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric	Size	Δ vs base	Budget
Eager (shipped) entry + static imports	2.29 MiB · 18 files	🔺 +979 B (+0.0%)	████░░░░░░ 40.0% of 5.72 MiB
Deferred (lazy)	2.11 MiB · 40 files	no change	n/a — loads on demand
Loader dist/toolbar.js	1.2 KiB	no change	█░░░░░░░░░ 6.0% of 19.5 KiB

Largest eagerly-shipped chunks

Size	File
902.3 KiB	dist/toolbar/toolbar-app-M4RZCOGY.css
692.2 KiB	dist/toolbar/chunk-chunk-72MXZPGR.js
260.7 KiB	dist/toolbar/chunk-chunk-L6XVLVLY.js
131.8 KiB	dist/toolbar/chunk-chunk-FDH2IBXT.js
130.4 KiB	dist/toolbar/chunk-chunk-C5NTA2OX.js
74.8 KiB	dist/toolbar/toolbar-app-3CZKXE2Y.js
69.0 KiB	dist/toolbar/chunk-chunk-TSAL54PB.js
35.6 KiB	dist/toolbar/chunk-chunk-HSGY7DL5.js
21.7 KiB	dist/toolbar/chunk-chunk-VFPSU72W.js
6.8 KiB	dist/toolbar/chunk-chunk-DV7IWQNF.js

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

✅ Dist folder size — 🔺 +454.2 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1022.85 MiB · 🔺 +454.2 KiB (+0.0%)

⚠️ Playwright — 1 flaky

🎭 Playwright report · View test results →

⚠️ 1 flaky test:

• create experiment via wizard, add metrics, and launch (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this section? Help fix flakies and failures and it will go green!

✅ Django migration risk — no migrations to analyze

No Django migrations need risk analysis.

[greptile-apps]

[Medium risk] Adds warehouse suggestions UI and feature flag.

Fix the missing suggestions, failed-status recovery, dismissal race, and repository-rule violations before merging.

_{Reviews (1) · Last reviewed commit: "chore(frontend): sort the feature flag t..." · Reviewed by Greptile}

[trunk-io]

   

Failed Test	Failure Summary	Logs
Experiment lifecycle › creation and launch › create experiment via wizard, add metrics, and launch	The test failed because waiting for the URL to change timed out after 15 seconds.	Logs ↗︎

View Full Report ↗︎ ⋅ Docs

[coderabbitai]

📝 Walkthrough

The frontend adds warehouse suggestion loading, status handling, acceptance and dismissal actions, and materialization controls. A feature flag enables suggestion views in data modeling and the catalog. The change also adds suggestion activity descriptions, evidence and duration formatting, interval mappings, tests, and Storybook examples.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 916c4

The suggestion UI sits behind a feature flag. Some freshness and savings copy may read oddly or understate data age. Merging carries low risk, and these copy fixes can follow.

Security architecture risk: 🔵 Low · up to 916c4

The new actions retain project and subject permissions, server-side schedule validation, and safeguards against repeated decisions. No security bypass was demonstrated. Uncertainty remains around interrupted requests, navigation, and downstream recovery.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• observed — Reachable state changes include scheduled materialization of editable saved queries and certification or deprecation of editable views or tables. An authorized user can act on multiple accessible subjects, but each traced request is resolved under its project and subject permissions.

Trust Boundaries and Controls

• observed — Browser-supplied suggestion IDs and refresh intervals cross into an API protected by authentication, API scopes, project membership, feature enablement, and subject authorization. Team-scoped lookup prevents a stale suggestion ID submitted under a different project from directly selecting that suggestion for mutation.

Resilience and Maintainability Implications

• observed — The existing acceptance transition locks the team-scoped suggestion, permits new acceptance only from proposed state, and returns an already accepted suggestion without repeating its acceptor. Dismissal also locks the row and rejects disallowed or repeated decisions. These controls contain concurrent decision races; they do not alone prove atomic recovery of downstream external jobs.

Pre-merge checks: 1

Check name	Status	Explanation
Description check		The pull request description is complete and follows the repository template. It includes the problem, user-visible changes, screenshots, testing scope and rationale, release status, docs status, agen…

Full details: Description check

Explanation

The pull request description is complete and follows the repository template. It includes the problem, user-visible changes, screenshots, testing scope and rationale, release status, docs status, agent context, invoked skills, and out-of-scope items. It also clearly identifies tests that were not run.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (3)

products/warehouse_suggestions/frontend/components/MaterializeSuggestionModal.tsx (1)

23-25: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Block modal dismissal while the accept request is in flight.

The Cancel button is disabled while inFlight is true. Esc, an overlay click, and the X button still call closeMaterializeModal. If the request then fails with a refused schedule, materializeError is set on a modal that is already closed, and the user never sees it. Pass closable={!inFlight} to LemonModal.

products/warehouse_suggestions/frontend/suggestionCopy.ts (1)

42-47: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Handle the case where both savings are zero.

If saves_seconds_per_month is below 60 and saves_bytes_per_month is 0, humanizeBytes(0) returns "0 bytes". The card then says "saves about 0 bytes of scanning". Fall back to "under a minute of query time", or hide the saving clause.

products/warehouse_suggestions/frontend/warehouseSuggestionsLogic.ts (1)

218-238: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Load every proposed suggestion page.

The list endpoint caps each response at 100 items. The loader requests one page and keeps only results. If an enabled team has more than 100 proposed suggestions, later actionable suggestions do not reach surfaceSuggestions, so users cannot see or act on them.

Suggested fix

-                    loadSuggestions: async () =>
-                        (await warehouseSuggestionsList(projectId(), { status: 'proposed' })).results,
+                    loadSuggestions: async () => {
+                        const suggestions: WarehouseSuggestionApi[] = []
+                        let offset = 0
+                        let page
+                        do {
+                            page = await warehouseSuggestionsList(projectId(), {
+                                status: 'proposed',
+                                offset,
+                            })
+                            suggestions.push(...page.results)
+                            offset += page.results.length
+                        } while (page.results.length > 0 && suggestions.length < page.count)
+                        return suggestions
+                    },

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
• Review profile: QUIET
• Plan: Enterprise
• Run ID: b48924da-4d65-4223-9629-e927e3c7ae37

📥 Commits

Reviewing files that changed from the base of the PR and between 71ced80 and a2acd1d.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (19)

• frontend/src/lib/components/ActivityLog/describers.tsx
• frontend/src/lib/constants.tsx
• frontend/src/types.ts
• products/data_catalog/frontend/tabs/CertificationsTab.tsx
• products/data_modeling/frontend/ViewsTab.tsx
• products/warehouse_suggestions/frontend/components/DismissSuggestionMenu.tsx
• products/warehouse_suggestions/frontend/components/MaterializeSuggestionCard.tsx
• products/warehouse_suggestions/frontend/components/MaterializeSuggestionModal.tsx
• products/warehouse_suggestions/frontend/components/SuggestedCertificationsTable.stories.tsx
• products/warehouse_suggestions/frontend/components/SuggestedCertificationsTable.tsx
• products/warehouse_suggestions/frontend/components/SuggestedModelsStrip.stories.tsx
• products/warehouse_suggestions/frontend/components/SuggestedModelsStrip.tsx
• products/warehouse_suggestions/frontend/components/WhyThisSuggestion.tsx
• products/warehouse_suggestions/frontend/refreshIntervals.ts
• products/warehouse_suggestions/frontend/suggestionCopy.ts
• products/warehouse_suggestions/frontend/warehouseSuggestionActivityDescriber.tsx
• products/warehouse_suggestions/frontend/warehouseSuggestionsLogic.test.ts
• products/warehouse_suggestions/frontend/warehouseSuggestionsLogic.ts
• products/warehouse_suggestions/package.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

[coderabbitai]

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)

products/warehouse_suggestions/frontend/suggestionCopy.ts (1)

63-74: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Fix spokenDuration for values that are not whole multiples of the units.

When parts.length reaches maxUnits, the loop keeps iterating. This is harmless for output. But a duration with a remainder below one minute, such as 90 seconds, prints "1 minute". The 30 seconds are dropped without any rounding. Example: freshnessSentence with freshness_after_seconds of 3659 prints "1 hour" for a value that is 59 seconds over. This understates the age of the data by up to 59 seconds, and by up to a full unit when maxUnits cuts off a lower unit. Use ceiling rounding for the last kept unit, or state the value as "about". The copy "up to X old" is an upper bound. Truncation therefore shows a bound that is too low.

Also, the input 0 or a value under 60 seconds returns 'under a minute'. For freshnessSentence, spokenDuration(payload.refresh_interval_seconds, 1) then reads "Refreshes every under a minute". Handle this case in the sentence.

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
• Review profile: QUIET
• Plan: Enterprise
• Run ID: 9ce3612c-ed3e-404d-b91c-048c781e31f3

📥 Commits

Reviewing files that changed from the base of the PR and between 0814268 and 916c49e.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• products/warehouse_suggestions/frontend/components/MaterializeSuggestionModal.tsx
• products/warehouse_suggestions/frontend/suggestionCopy.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

[posthog]

PostHog Review · Standard · reviewed ee1faca: 2 Should fix. This pull request is large, so the review ran in 4 parts with less depth than usual.

[posthog]

PostHog Review · Standard · reviewed 3ee3431: no findings. This pull request is large, so the review ran in 4 parts with less depth than usual.

[posthog]

🕓 This approval covered an earlier revision. There are new visual changes to review in the newer comment below.

✅ Visual changes approved by @thiagosalvatore — baseline updated in 52fd270.

View this run in PostHog

8 changed, 4 new.

_{Install the Visual Review Chrome extension to see visual review results at the top of your pull requests.}

[thiagosalvatore]

@PostHog review --deep

[posthog]

@thiagosalvatore PostHog Review is reviewing this pull request.

[posthog]

PostHog Review · Deep · reviewed 52fd270

Posted 5 findings: 1 Should fix, 4 Consider.

Step	Status	Result
Prepare the diff	done	36 files, 7 chunks
Pick perspectives	done	3 perspectives
Run review passes	done	13 issues (+2 blind-spot)
Merge overlapping findings	done	15 → 11
Validate findings	done	5 kept, 6 dismissed
Publish	done	5 posted (view review)

[posthog]

This is review round 3 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.

[sinan-ku]

Really exciting!! Got some nits but happy to ship!

[posthog]

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

_{Install the Visual Review Chrome extension to see visual review results at the top of your pull requests.}

[deployment-status-posthog]

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-10-23 18:54 UTC	Run
prod-us	✅ Deployed	2026-10-23 19:10 UTC	Run
prod-eu	✅ Deployed	2026-10-23 19:06 UTC	Run