Skip to content

docs: require signed commits in contributor docs - #151

Merged
turnipdabeets merged 1 commit into
mainfrom
docs/commit-signing
Oct 23, 2026
Merged

turnipdabeets merged 1 commit into
mainfrom
docs/commit-signing

Conversation

@turnipdabeets

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

main requires signed commits, but nothing in this repo's contributor docs says so. Contributors, especially first-timers and agent-driven ones, keep opening PRs with unsigned commits. Maintainers then have to ask for re-signing before merging. This ports PostHog/posthog-js#5394.

Changes (docs only, no changeset):

  • CONTRIBUTING.md: "Commit signing" section linking to the handbook guide. It tells contributors to set commit.gpgsign to true.
  • AGENTS.md: one line telling agents to sign every commit in the git config they commit with.
  • PR template: "All commits are signed" checklist item.

💚 How did you test it?

Docs only. I read the rendered diff and checked that the handbook anchor #commit-signing exists.

📝 Checklist

  • All commits are signed (see Commit signing)
  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Claude Code (Opus) ported the same docs change across the PostHog SDK repos after a maintainer noticed first-time contributors repeatedly opening unsigned PRs. The wording is the same in every repo.

🤖 Generated with Claude Code

Contributors often open PRs with unsigned commits because signing isn't documented here.
@turnipdabeets
turnipdabeets requested a review from a team as a code owner October 22, 2026 22:20
@turnipdabeets turnipdabeets self-assigned this Oct 22, 2026
@turnipdabeets
turnipdabeets enabled auto-merge (squash) October 22, 2026 22:21
@github-actions

Copy link
Copy Markdown
Contributor

posthog-unity Compliance Report

Date: 2026-10-22 22:22:57 UTC
Duration: 105644ms

✅ All Tests Passed!

46/46 tests passed


Capture Tests

✅ 29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields ✅ 56ms
Format Validation.Event Has Uuid ✅ 8ms
Format Validation.Event Has Lib Properties ✅ 6ms
Format Validation.Distinct Id Is String ✅ 5ms
Format Validation.Token Is Present ✅ 5ms
Format Validation.Custom Properties Preserved ✅ 9ms
Format Validation.Event Has Timestamp ✅ 5ms
Retry Behavior.Retries On 503 ✅ 6517ms
Retry Behavior.Does Not Retry On 400 ✅ 2013ms
Retry Behavior.Does Not Retry On 401 ✅ 2009ms
Retry Behavior.Respects Retry After Header ✅ 8018ms
Retry Behavior.Implements Backoff ✅ 18531ms
Retry Behavior.Retries On 500 ✅ 5514ms
Retry Behavior.Retries On 502 ✅ 5516ms
Retry Behavior.Retries On 504 ✅ 5515ms
Retry Behavior.Max Retries Respected ✅ 18530ms
Deduplication.Generates Unique Uuids ✅ 11ms
Deduplication.Preserves Uuid On Retry ✅ 5513ms
Deduplication.Preserves Uuid And Timestamp On Retry ✅ 11522ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry ✅ 5517ms
Deduplication.No Duplicate Events In Batch ✅ 10ms
Deduplication.Different Events Have Different Uuids ✅ 6ms
Compression.Sends Gzip When Enabled ✅ 7ms
Batch Format.Uses Proper Batch Structure ✅ 5ms
Batch Format.Flush With No Events Sends Nothing ✅ 2ms
Batch Format.Multiple Events Batched Together ✅ 9ms
Error Handling.Does Not Retry On 403 ✅ 2007ms
Error Handling.Does Not Retry On 413 ✅ 2018ms
Error Handling.Retries On 408 ✅ 5514ms

Feature_Flags Tests

✅ 17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id ✅ 17ms
Request Payload.Flags Request Uses V2 Query Param ✅ 5ms
Request Payload.Flags Request Hits Flags Path Not Decide ✅ 3ms
Request Payload.Flags Request Omits Authorization Header ✅ 4ms
Request Payload.Token In Flags Body Matches Init ✅ 4ms
Request Payload.Groups Round Trip ✅ 3ms
Request Payload.Groups Default To Empty Object ✅ 4ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False ✅ 3ms
Request Payload.Disable Geoip Omitted Defaults To False ✅ 5ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key ✅ 4ms
Request Lifecycle.No Flags Request On Init Alone ✅ 1ms
Request Lifecycle.No Flags Request On Normal Capture ✅ 4ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests ✅ 5ms
Request Lifecycle.Mock Response Value Is Returned To Caller ✅ 4ms
Retry Behavior.Retries Flags On 502 ✅ 507ms
Retry Behavior.Retries Flags On 504 ✅ 507ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event ✅ 6ms

@turnipdabeets
turnipdabeets merged commit d28a9e6 into main Oct 23, 2026
17 checks passed
@turnipdabeets
turnipdabeets deleted the docs/commit-signing branch October 23, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants