Repository navigation
chore: sync main into v1 (7.83.0–7.83.1, flags v4) - #1175
Merged
Merged
Conversation
turnipdabeets
approved these changes
Nov 4, 2026
turnipdabeets
left a comment
Contributor
There was a problem hiding this comment.
Picks match upstream. In #1031 the only differences are v1's sdk-compliance workflow (harness 1.26.0, which is newer than main's 1.23.0) and flags_response_v4 added to v1's capability list. The parity-test fix is correct: v1 reads self.before_send when the event is sent and adds flag properties inside _enqueue, so reading in before_send compares the real events. Nothing on main up to 7.83.1 was skipped.
(cherry picked from commit e094dc5)
(cherry picked from commit 43c7545)
(cherry picked from commit 314fad0)
(cherry picked from commit 9f5d458)
(cherry picked from commit 06e5611)
v1 passes flag properties to _enqueue separately and layers them while building the event, so a stubbed _enqueue never saw them. Reading the built event in before_send compares v1's real output with 7.82.1. Co-Authored-By: Claude Opus 5.5 <[email protected]>
eli-r-ph
force-pushed
the
eli/v1-sync-main-7.83
branch
from
November 4, 2026 20:50
19ef105 to
9f25ef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
mainshipped 7.83.0 and 7.83.1 after #1174, so 8.0 would keep reading the/flags?v=2response (#1031) and miss the MCP 2.x context fix (#1166). #1031 is the largestmainchange since the last sync, so it gets its own PR. Stacked on #1174.Changes
-xpicks of the sixmaincommits after chore: sync main into v1 (7.81.2–7.82.2) #1174, in order, release and reference commits included: feat(flags): read the /flags?v=4 response #1031, 7.83.0, fix(mcp): inject context into mcp 2.x tool objects and test without fastmcp #1166, 7.83.1 and their reference updates. None skipped.async_client.py: v1's import lists, with feat(flags): read the /flags?v=4 response #1031's removals (_metadata_has_experiment,_parse_flag_payload,FlagMetadata) and additions applied.request.py: v1'spost()call, now to/flags/?v=4.sdk-compliance.yml: v1's workflow kept. It runs harness 1.26.0 directly, newer thanmain's 1.23.0 pin.flags_response_v4added to v1's capability list, and asserted in v1's capability test._enqueueto read events, but v1 adds flag properties inside_enqueue, so the stub saw none and the 7.82.1 comparison failed. The tests now read the built event inbefore_send, so they compare v1's real output with 7.82.1 and pass. This also stops the v2/v4 comparison from passing with empty flag properties./flagsrequest and how its response is read.FlagMetadata.idand.versionbecome optional, as onmain.💚 How did you test it?
pytest, ruff, mypy,check_public_api.pyanduv lock --checklocally: 6322 passed. The three metrics-autocapture fork tests fail on macOS, as on unmodifiedmain(chore: sync main into v1 (7.75.7–7.81.1) #1169).+/-lines match its upstream commit, except the feat(flags): read the /flags?v=4 response #1031 resolutions above.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
claude-opus-5-5), following the release runbook's main-sync step and chore: sync main into v1 (7.75.7–7.81.1) #1169's method.🤖 Generated with Claude Code