Repository navigation
fix: whole-second timestamps and 8.0 migration guide gaps - #1168
Merged
Merged
Conversation
4 of 6 tasks
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Event timestamp, batch created_at and PostHog-Request-Timestamp now use one helper that writes six fractional digits in UTC, so whole seconds no longer lose the fraction. Co-Authored-By: Claude Opus 5.5 <[email protected]>
eli-r-ph
force-pushed
the
eli/v1-guide-review-fixes
branch
from
November 2, 2026 17:10
ff0e820 to
57e9198
Compare
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
|
[suggestion] |
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
updated, thank you! |
turnipdabeets
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
A review of the 8.0 migration guide against the
v1code found upgrade risks it did not mention. The biggest one: person processing turned off in a context or insuper_optionsnow reachesaliasandgroup_identify, so PostHog drops their$create_aliasand$groupidentifyevents with noon_errorreport.Changes
timestamp,created_at,PostHog-Request-Timestamp) now always has six fractional digits.isoformat()dropped the fraction on whole seconds, which breaks the at-least-milliseconds rule every v1 SDK follows.super_optionssetting on$create_aliasand$groupidentify.sync_modenow retries up to 4 attempts in the calling thread (7.x made one).capture()does not move$ai_events to the AI endpoint, andcapture_aiwith a non-$ai_name is dropped asmisrouted_event.invalid_options.CaptureModein the removed imports,gzip=as a keyword, reason tags in the loss line, the removedError in capture:sync line, the 7.x first retry wait,NaNin$set, and when trace ids are added.💚 How did you test it?
New
test_wire_timestamps_keep_fractional_digits_on_whole_secondscovers sync, background and async sends with whole-second clock and caller times; it fails without the fix. Guide lines were checked against the code onv1and 7.x onmain, and thesync_modeattempts were checked with a local stub server.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
claude-opus-5-5) from a review of the guide againstv1and the capture service. Merges cleanly with fix(ai): treat an empty or whitespace distinct id as missing in AI integrations #1158 and docs: ask users to review before_send hooks for the v1 event shape #1159. CI needs ci: pin Python 3.11 by minor version for Ubuntu 26.04 runners (v1) #1160 first, like the other open PRs.🤖 Generated with Claude Code