Skip to content

test: an event JSON cannot serialize is dropped alone #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eli-r-ph merged 2 commits into from
Oct 28, 2026
Merged

test: an event JSON cannot serialize is dropped alone #1138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dca06e
test: an event JSON cannot serialize is dropped alone
eli-r-ph Oct 28, 2026
fb96aaf
test: cover an event that fails json after it is queued
eli-r-ph Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions posthog/test/test_before_send.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
)


_CIRCULAR: dict = {}
_CIRCULAR["self"] = _CIRCULAR


class TestClient(unittest.TestCase):
@classmethod
def setUpClass(cls):
Expand Down Expand Up @@ -259,6 +263,10 @@ def test_before_send_callback_non_dict_output_drops_event(self):
"private-value",
["malformed", "valid"],
),
# A circular value fails cleaning, so its event is dropped before it is queued.
("circular_reference", "private-key", _CIRCULAR, ["valid"]),
Comment thread
eli-r-ph marked this conversation as resolved.
# A value that survives cleaning but not json costs only its queued event.
("unserializable_value", "private-key", complex(1, 2), ["valid"]),
]
)
def test_malformed_before_send_event_does_not_stop_consumer_or_shutdown(
Expand Down
Loading