Repository navigation
chore: run the capture v1 compliance suites from harness 1.25.0 - #1137
Conversation
Declare the adapter capabilities harness 1.23.0 uses to gate tests: event_uuid_override, bounded_retries, disable_geoip and historical_migration. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…loads, property_layers and fail_open features Co-Authored-By: Claude Opus 5.5 <[email protected]>
dustinbyrne
left a comment
dustinbyrne
left a comment
There was a problem hiding this comment.
The adapter additions look sound overall, but published harness 1.23.0 contains an unrelated flags update and its capture contracts are unchanged from 1.13.1. Please select the release containing the intended capture suites before relying on this CI coverage. Two optional adapter edge cases are noted inline. Formatting and full compliance runs against the correct release remain outstanding.
AI-assisted review.
…e padding markers in bytes Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
eli-r-ph
changed the title
dustinbyrne
left a comment
dustinbyrne
left a comment
There was a problem hiding this comment.
The harness release selection, reset ordering and marker-byte sizing fixes are verified. The intended compliance cases now run successfully across all three codecs. One optional adapter diagnostic edge case is noted inline; it does not block acceptance.
AI-assisted review.
Also point adapter docs at harness 1.25.0. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
💡 Motivation and Context
Harness 1.25.0 (posthog-sdk-test-harness#92) brings the
capture_v1andcapture_ai_v1suites up to date with capture v1: 404, 429 and 502 retries, the SDK's own backoff,duplicates_dropped, thewarningresult, caller uuids in lowercase, AI routing and lane isolation. It also gates some tests behind new adapter capabilities.Pin the compliance job to harness
1.25.0.Declare
event_uuid_override,bounded_retries,disable_geoipandhistorical_migration, which this adapter already supports. Without them those tests are skipped.Support the newer harness features (posthog-sdk-test-harness#95) and declare them:
reported_drops(fromon_error),log_capture(theposthoglogger),generated_payloads,property_layers(super_propertiesandbefore_send) andfail_open.Harness 1.25.0 is published (posthog-sdk-test-harness #92, #94 and #95).
💚 How did you test it?
Ran every harness suite from the #92 branch locally against this adapter on
v1with these capabilities declared: 235/235 passed, including the new tests. Adapter unit tests pass, with the capability assertion extended.Both v1 suites from the posthog-sdk-test-harness#95 branch, with these features: 223/223.
📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Claude Opus 5.5) wrote this change as part of the harness update and ran the compliance suites locally against the adapter.
🤖 Generated with Claude Code