Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #1078.
Event properties containing non-finite floats (
inf,-inf,nan) were serialized withjson.dumps' defaultallow_nan=True, producing the bare tokensInfinity/NaN. Those aren't valid JSON, so strict parsers downstream reject the whole batch and every event in it is lost.This change makes
utils.clean()coerce non-finite floats toNone(sent asnull), matching posthog-js, whereJSON.stringifydoes the same. I went with coercion over raising because raising would drop the caller's entire event over one bad property.clean()returnsNonefor anyfloatthat isn'tmath.isfinite.Decimalbranch now runs its converted float back throughclean(). Previously it returnedfloat(item)directly, soDecimal("Infinity")would skip the new check and still serialize asInfinity.Since
clean()already recurses through dicts, lists, tuples, sets, dataclasses and pydantic models, nested values are covered too.💚 How did you test it?
test_clean_non_finite_floats(parameterized:inf,-inf,nan,Decimal("Infinity"), plus finite float/Decimal passthrough) andtest_clean_non_finite_floats_nested.clean()+json.dumps(..., cls=DatetimeSerializer), including a nestedDecimal("Infinity"): the payload is now{"score": null, "ratio": null, "ok": 1.5, ...}and passes a strictjson.loads(..., parse_constant=...)that rejectsInfinity/NaN.pytest --timeout=30→ 4706 passed, 16 skipped.ruff format --check .,ruff check ., the mypy baseline check, andpython -W error -c "import posthog"all pass.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)