Repository navigation
feat(error-tracking): add ambient trace IDs to exceptions - #262
Conversation
Generated-By: PostHog Desktop Task-Id: 5681be44-4986-48db-b140-1bda88f75f96
There was a problem hiding this comment.
PostHog Review · Standard · reviewed e0f393c: 1 Should fix.
This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.
posthog-php-fork_curl Compliance ReportDate: 2026-10-19T11:28:09.790243+00:00
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 35ms |
| Format Validation.Event Has Uuid | ✅ | 530ms |
| Format Validation.Event Has Lib Properties | ✅ | 531ms |
| Format Validation.Distinct Id Is String | ✅ | 530ms |
| Format Validation.Token Is Present | ✅ | 530ms |
| Format Validation.Custom Properties Preserved | ✅ | 533ms |
| Format Validation.Event Has Timestamp | ✅ | 531ms |
| Format Validation.Non Utc Event Timestamp Is Converted To Utc | ✅ | 531ms |
| Retry Behavior.Retries On 503 | ❌ | 5532ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 2536ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 2532ms |
| Retry Behavior.Respects Retry After Header | ❌ | 5537ms |
| Retry Behavior.Implements Backoff | ❌ | 15548ms |
| Retry Behavior.Retries On 500 | ❌ | 5536ms |
| Retry Behavior.Retries On 502 | ❌ | 5538ms |
| Retry Behavior.Retries On 504 | ❌ | 5540ms |
| Retry Behavior.Max Retries Respected | ❌ | 15545ms |
| Deduplication.Generates Unique Uuids | ✅ | 539ms |
| Deduplication.Preserves Uuid On Retry | ❌ | 5536ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ❌ | 10544ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ❌ | 5538ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 541ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 534ms |
| Compression.Sends Gzip When Enabled | ✅ | 533ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 531ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 519ms |
| Batch Format.Multiple Events Batched Together | ✅ | 521ms |
| Error Handling.Does Not Retry On 403 | ✅ | 2533ms |
| Error Handling.Does Not Retry On 413 | ✅ | 2535ms |
| Error Handling.Retries On 408 | ❌ | 5531ms |
Failures
retry_behavior.retries_on_503
Expected at least 3 requests, got 1
retry_behavior.respects_retry_after_header
Expected at least 2 requests, got 1
retry_behavior.implements_backoff
Expected at least 3 requests, got 1
retry_behavior.retries_on_500
Expected at least 2 requests, got 1
retry_behavior.retries_on_502
Expected at least 2 requests, got 1
retry_behavior.retries_on_504
Expected at least 2 requests, got 1
retry_behavior.max_retries_respected
Expected 4 requests, got 1
deduplication.preserves_uuid_on_retry
Need at least 2 requests to check retry
deduplication.preserves_uuid_and_timestamp_on_retry
Expected at least 3 requests, got 1
deduplication.preserves_uuid_and_timestamp_on_batch_retry
Expected at least 2 requests, got 1
error_handling.retries_on_408
Expected at least 2 requests, got 1
Feature_Flags Tests
✅ 17/17 tests passed
View Details
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ✅ | 528ms |
| Request Payload.Flags Request Uses V2 Query Param | ✅ | 522ms |
| Request Payload.Flags Request Hits Flags Path Not Decide | ✅ | 522ms |
| Request Payload.Flags Request Omits Authorization Header | ✅ | 523ms |
| Request Payload.Token In Flags Body Matches Init | ✅ | 522ms |
| Request Payload.Groups Round Trip | ✅ | 521ms |
| Request Payload.Groups Default To Empty Object | ✅ | 522ms |
| Request Payload.Disable Geoip False Propagates As Geoip Disable False | ✅ | 521ms |
| Request Payload.Disable Geoip Omitted Defaults To False | ✅ | 522ms |
| Request Payload.Flag Keys To Evaluate Contains Only Requested Key | ✅ | 522ms |
| Request Lifecycle.No Flags Request On Init Alone | ✅ | 517ms |
| Request Lifecycle.No Flags Request On Normal Capture | ✅ | 517ms |
| Request Lifecycle.Two Flag Calls Produce Two Remote Requests | ✅ | 524ms |
| Request Lifecycle.Mock Response Value Is Returned To Caller | ✅ | 524ms |
| Retry Behavior.Retries Flags On 502 | ✅ | 626ms |
| Retry Behavior.Retries Flags On 504 | ✅ | 624ms |
| Side Effect Events.Get Feature Flag Captures Feature Flag Called Event | ✅ | 532ms |
posthog-php-lib_curl Compliance ReportDate: 2026-10-19T11:27:58.320958+00:00 ✅ All Tests Passed!47/47 tests passed Capture Tests✅ 30/30 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
posthog-php-socket Compliance ReportDate: 2026-10-19T11:28:36.265676+00:00
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 20ms |
| Format Validation.Event Has Uuid | ✅ | 516ms |
| Format Validation.Event Has Lib Properties | ✅ | 517ms |
| Format Validation.Distinct Id Is String | ✅ | 517ms |
| Format Validation.Token Is Present | ✅ | 516ms |
| Format Validation.Custom Properties Preserved | ✅ | 518ms |
| Format Validation.Event Has Timestamp | ✅ | 516ms |
| Format Validation.Non Utc Event Timestamp Is Converted To Utc | ✅ | 518ms |
| Retry Behavior.Retries On 503 | ❌ | 9224ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 2521ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 2521ms |
| Retry Behavior.Respects Retry After Header | ❌ | 9226ms |
| Retry Behavior.Implements Backoff | ❌ | 19238ms |
| Retry Behavior.Retries On 500 | ❌ | 9225ms |
| Retry Behavior.Retries On 502 | ❌ | 8731ms |
| Retry Behavior.Retries On 504 | ❌ | 9229ms |
| Retry Behavior.Max Retries Respected | ❌ | 19238ms |
| Deduplication.Generates Unique Uuids | ✅ | 523ms |
| Deduplication.Preserves Uuid On Retry | ❌ | 9227ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ❌ | 14233ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ❌ | 9230ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 523ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 517ms |
| Compression.Sends Gzip When Enabled | ✅ | 518ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 517ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 515ms |
| Batch Format.Multiple Events Batched Together | ✅ | 508ms |
| Error Handling.Does Not Retry On 403 | ✅ | 2519ms |
| Error Handling.Does Not Retry On 413 | ✅ | 2519ms |
| Error Handling.Retries On 408 | ❌ | 5522ms |
Failures
retry_behavior.retries_on_503
Expected at least 3 requests, got 1
retry_behavior.respects_retry_after_header
Expected at least 2 requests, got 1
retry_behavior.implements_backoff
Expected at least 3 requests, got 1
retry_behavior.retries_on_500
Expected at least 2 requests, got 1
retry_behavior.retries_on_502
Expected at least 2 requests, got 1
retry_behavior.retries_on_504
Expected at least 2 requests, got 1
retry_behavior.max_retries_respected
Expected 4 requests, got 1
deduplication.preserves_uuid_on_retry
Need at least 2 requests to check retry
deduplication.preserves_uuid_and_timestamp_on_retry
Expected at least 3 requests, got 1
deduplication.preserves_uuid_and_timestamp_on_batch_retry
Expected at least 2 requests, got 1
error_handling.retries_on_408
Expected at least 2 requests, got 1
Feature_Flags Tests
✅ 17/17 tests passed
View Details
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ✅ | 517ms |
| Request Payload.Flags Request Uses V2 Query Param | ✅ | 515ms |
| Request Payload.Flags Request Hits Flags Path Not Decide | ✅ | 516ms |
| Request Payload.Flags Request Omits Authorization Header | ✅ | 515ms |
| Request Payload.Token In Flags Body Matches Init | ✅ | 517ms |
| Request Payload.Groups Round Trip | ✅ | 515ms |
| Request Payload.Groups Default To Empty Object | ✅ | 516ms |
| Request Payload.Disable Geoip False Propagates As Geoip Disable False | ✅ | 516ms |
| Request Payload.Disable Geoip Omitted Defaults To False | ✅ | 514ms |
| Request Payload.Flag Keys To Evaluate Contains Only Requested Key | ✅ | 516ms |
| Request Lifecycle.No Flags Request On Init Alone | ✅ | 512ms |
| Request Lifecycle.No Flags Request On Normal Capture | ✅ | 507ms |
| Request Lifecycle.Two Flag Calls Produce Two Remote Requests | ✅ | 518ms |
| Request Lifecycle.Mock Response Value Is Returned To Caller | ✅ | 517ms |
| Retry Behavior.Retries Flags On 502 | ✅ | 616ms |
| Retry Behavior.Retries Flags On 504 | ✅ | 618ms |
| Side Effect Events.Get Feature Flag Captures Feature Flag Called Event | ✅ | 518ms |
Generated-By: PostHog Desktop Task-Id: 5681be44-4986-48db-b140-1bda88f75f96
|
Note 🤖 Automated comment by QA Swarm - not written by a human Verdict: APPROVE (round 2 @ 8bbc2c9)No new exception trace defect found. Manual and automatic capture preserve request and caller trace values. Missing or failing OpenTelemetry context does not stop exception capture. Key findingsThe earlier manual context priority finding is fixed in ConvergenceThe earlier finding was checked and resolved. No further quality work remains at this unchanged commit. The simplify pass proposed no change. The SDK spec agreement remains a merge hold. Reviewer summaries
The CI checks pass. The Socket and foreground ForkCurl compliance reports still show transport retry failures. Those require separate transport fixes; this verdict does not certify full SDK compliance. Automated by QA Swarm - not a human review |
# Conflicts: # composer.lock
[Robot] Draft prepared with Codex.
💡 Motivation and Context
Developers need to find the trace for a captured error. PHP exception events do not include IDs from the active OpenTelemetry span.
$trace_idand$span_idto manual and automatic exception events when the application provides a valid active span.This draft implements the proposed exception trace contract and waits for agreement there before merge.
💚 How did you test it?
📝 Checklist
If releasing new changes
pnpm changeto generate a change intent file. Added the change intent directly because the pinned pnpm download failed certificate validation.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Codex (gpt-6) used shell commands, Git, Composer, PHPUnit, PHP_CodeSniffer, and the GitHub CLI. The change uses one shared internal helper for manual and automatic capture. OpenTelemetry remains optional at runtime. Human review is required. Skills: writing-tests and writing-pr-descriptions.
Created with PostHog Desktop