Repository navigation
chore(react-native-plugin)!: require posthog-android 4.0 - #5476
Conversation
There was a problem hiding this comment.
PostHog Review · Standard · reviewed bfa07d1: 1 Must fix.
This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.
See this review and its findings in PostHog Review. Comment @posthog review --deep for a Deep review. A Deep review takes longer and looks deeper than a Standard review.
Coherence📄 0 spec file errors · ⛔ 0 broken rules · 🚪 2 unchecked inputs · 🐛 0 bugs that came back What is Coherence?Coherence compares the code with its spec files ( This check read 44 parts of the code and 7 rules. Note These findings do not make this check fail. None of these findings are in files that this pull request changes. You do not need to fix them in this pull request. 🚪 Unchecked inputs (2)
What this means and how to fix itInput from outside this code comes in at these places. The spec does not say what checks that input. 10 more places were already like this when Coherence was added. This list does not show them. To close one of these, find the place by its name in the
To get the line to add, run |
dustinbyrne
left a comment
There was a problem hiding this comment.
The native dependency pin and major changeset fit the plugin 3.0 upgrade. No additional issue found in the inspected wrapper/API paths. Merge remains gated on the published Android 4.0 artifact, final compatibility recheck and green Android native CI.
AI-assisted review.
c15386c to
c81d985
Compare
bfa07d1 to
2dc8317
Compare
|
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
* chore(react-native-plugin)!: require posthog-android 4.0 * docs(react-native-plugin): fold posthog-android 4.0 notes into the 3.0 changeset and guide * chore(react-native-plugin): drop posthog-android's screenshot option
Warning
Prep PR: CI is expected to fail until posthog-android 4.0 is released.
com.posthog:posthog-android:4.0.0isn't on Maven Central yet. Merge into #5194 once 4.0 is published and CI is green. This is the Android side of #5237 (posthog-ios 4.0).Problem
#5194 (plugin 3.0) keeps posthog-android at 3.71.6. posthog-android 4.0 (PostHog/posthog-android#871) is coming. If plugin 3.0 is going to pick it up, it has to happen in this major.
Changes
packages/react-native-plugin/android/build.gradlenow depends oncom.posthog:posthog-android:4.0.0..changeset/rn-plugin-v3.md: Breaking, require posthog-android 4.0.sessionReplayConfig.screenshot = true, which chore!: remove wireframe session replay capture posthog-android#908 removes, I don't expect the plugin's Kotlin to need any changes. I checked its calls against the 4.0 branch (chore/v4-remove-deprecated) API dump:PostHogAndroidConfig(apiKey, host)passes the token by position. The 4.0 constructor's first parameter isprojectToken, so the call still works.PostHogPreferences, includingANONYMOUS_ID/DISTINCT_ID, andPostHogSessionManager) stay public. chore!: make SDK-internal helpers non-public posthog-android#872 keeps them public for the wrappers.remoteConfig,debouncerDelayMs,propertiesSanitizer,getFeatureFlagPayload,PostHogOnFeatureFlags).minSdk23 and the same Kotlin settings.posthog-android-surveys-compose) that the plugin doesn't depend on.Before merging
4.0.x./i/v1/analytics/events, so reverse proxies have to forward that path. Add an entry to.changeset/rn-plugin-v3.mdfor it if so.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Made with Claude Code. I checked compatibility statically against the posthog-android 4.0 branch's API dump and source. Not tested: building the plugin against a local 4.0 build, or running the app.
🤖 Generated with Claude Code