Repository navigation
docs: drop the full-window ph-no-capture exception from the migration guide - #980
Merged
turnipdabeets merged 1 commit intoOct 27, 2026
Conversation
… guide #970 masks a full-window ph-no-capture view and its descendants, so the exception no longer applies. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
#978 documented that a UIKit
ph-no-captureview filling the whole window isn't masked itself, only its subviews. #970 removes that exception: the view is masked whole and so are its descendants. This drops the paragraph so the guide matches 4.0.Merge after #970 reaches this branch (the next
main→chore/v4-remove-deprecatedmerge). Before that, the paragraph is still accurate here.💚 How did you test it?
Markdown only:
git diff --check. The table row it leaves ("A view and everything inside it") is what #970 implements; #970's tests cover the full-window case.📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code removed one paragraph from
MIGRATION.mdwhile addressing review comments on #970 and #978. It's a separate PR becauseMIGRATION.mdonly exists on the v4 branch, and #970 targetsmain.🤖 Generated with Claude Code