Skip to content

ci(release): synchronize nested module core minimums - #376

Merged
dustinbyrne merged 2 commits into
mainfrom
ci/synchronize-nested-core-minimums
Oct 21, 2026
Merged

dustinbyrne merged 2 commits into
mainfrom
ci/synchronize-nested-core-minimums

Conversation

@dustinbyrne

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

The release workflow already tags core, OTel, and the MCP adapter with one shared version, but leaves the nested modules' core requirements unchanged. A module can therefore ship with a minimum that does not support its new core-dependent behavior, even though checkout tests pass through the local replace.

Synchronize both core minimums to the computed release version before the automated version-bump commit. go mod edit updates the manifests without resolving the not-yet-published version. The existing commit and tagging steps then include those requirements in the release artifacts.

Update the release guide and MCP adapter instructions to describe this policy. Consumers can still select a newer core version. This is release-tooling/documentation only and does not need a changeset or an SDK release to take effect.

Related: #375.

💚 How did you test it?

  • Executed the actual synchronization shell block from the workflow against temporary copies of both modules' real manifests, with module downloads disabled (GOPROXY=off, GOSUMDB=off, GOTOOLCHAIN=local, GOWORK=off).
  • Patch (1.35.2), minor (1.36.0), and prerelease (1.36.0-rc.1) cases update both requirements correctly; other dependencies, local replacements, and checksums remain unchanged. Repeating the step is idempotent.
  • Verified a missing nested module fails the step before committing/tagging, and checked the workflow output wiring and ordering.
  • YAML parsing, bash -n, ShellCheck, and git diff --check pass.
  • Inspected the pinned commit action to confirm its default file selection includes both changed manifests.
  • A fresh read-only reviewer checked the change; its stale MCP documentation finding is addressed.

No live release, tag creation, or publishing was exercised. SDK runtime code is unchanged.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented with Pi and checked by a fresh read-only reviewer. The change keeps the existing shared-version release model and adds dependency synchronization within release preparation. Validation exercised the workflow's synchronization commands offline; the complete publishing workflow was not run.

@dustinbyrne
dustinbyrne requested a review from a team as a code owner October 19, 2026 20:08
@dustinbyrne dustinbyrne added the stamphog Request AI approval (no full review) label Oct 19, 2026
@dustinbyrne dustinbyrne self-assigned this Oct 19, 2026

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approved — this change needs a human reviewer.

Re-adding the stamphog label gives the same result unless the changed files change.

stamphog can't approve this pull request automatically. Two gates refused it. The deny-list gate matched the infra/CI-CD category because the change edits .github/workflows/release.yml. The tier gate classified it as T2-never (35 lines across 3 files, two areas, CI), which is never eligible for automated approval.

The size and prerequisites gates passed, so splitting the PR won't change the outcome while the workflow change is included. The author should ask a human maintainer to review it.

Gate mechanics and policy version
Gate Result
prerequisites ✓ all clear
deny-list ✗ matches: infra_cicd
size ✓ 14L, 1F substantive, 35L/3F incl. docs/generated/snapshots — within ceiling
tier ✗ classified as T2-never: T2-never (35L, 3F, two-areas, ci)
stamphog 2.6.0 .stamphog/policy.yml @ unknown · reviewed head 581a0c8

@stamphog stamphog Bot removed the stamphog Request AI approval (no full review) label Oct 19, 2026

@posthog posthog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog Review · Standard · reviewed 581a0c8: 1 Should fix.

Comment thread .github/workflows/release.yml
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

posthog-go Compliance Report

Date: 2026-10-19 20:29:48 UTC
Duration: 169039ms

✅ All Tests Passed!

111/111 tests passed


Capture_V1 Tests

✅ 94/94 tests passed

View Details
Test Status Duration
Endpoint And Method.Targets V1 Endpoint ✅ 27ms
Endpoint And Method.Does Not Use Legacy Endpoints ✅ 5ms
Required Headers.Has Authorization Bearer Header ✅ 5ms
Required Headers.Has Content Type Json ✅ 15ms
Required Headers.Has Posthog Sdk Info Format ✅ 16ms
Required Headers.Has Posthog Attempt Header ✅ 7ms
Required Headers.Has Posthog Request Id ✅ 5ms
Required Headers.Has Posthog Request Timestamp ✅ 5ms
Required Headers.Has User Agent ✅ 6ms
Body Format.Body Has Created At And Batch ✅ 4ms
Body Format.No Api Key In Body ✅ 5ms
Body Format.No Sent At In Body ✅ 5ms
Event Format.Event Has Required Root Fields ✅ 5ms
Event Format.Event Uuid Is Valid ✅ 5ms
Event Format.Event Timestamp Is Rfc3339 ✅ 5ms
Event Format.Distinct Id Is String ✅ 5ms
Event Format.Distinct Id At Root Not Properties ✅ 4ms
Event Format.Custom Properties Preserved ✅ 5ms
Event Format.Set Properties Preserved ✅ 5ms
Event Format.Set Once Properties Preserved ✅ 5ms
Event Format.Groups Properties Preserved ✅ 15ms
Event Format.Sdk Generates Uuid If Not Provided ✅ 6ms
Event Format.Event Has Required Root Fields Batch ✅ 7ms
Event Format.Event Uuid Is Valid Batch ✅ 7ms
Event Format.Event Timestamp Is Rfc3339 Batch ✅ 6ms
Event Format.Distinct Id Is String Batch ✅ 7ms
Event Format.Distinct Id At Root Not Properties Batch ✅ 7ms
Event Format.Custom Properties Preserved Batch ✅ 7ms
Event Format.Set Properties Preserved Batch ✅ 6ms
Event Format.Set Once Properties Preserved Batch ✅ 7ms
Event Format.Groups Properties Preserved Batch ✅ 7ms
Event Format.Sdk Generates Uuid If Not Provided Batch ✅ 6ms
Batch Behavior.Multiple Events In Single Batch ✅ 29ms
Batch Behavior.Batch Envelope Smoke ✅ 8ms
Batch Behavior.Flush With No Events Sends Nothing ✅ 3ms
Batch Behavior.Flush At Triggers Batch ✅ 1006ms
Batch Behavior.Created At Reflects Batch Creation Time ✅ 6ms
Deduplication.Generates Unique Uuids ✅ 11ms
Deduplication.Different Events Same Content Different Uuids ✅ 7ms
Deduplication.Preserves Uuid On Retry ✅ 5132ms
Deduplication.Preserves Timestamp On Retry ✅ 5134ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry ✅ 5136ms
Deduplication.No Duplicate Events In Batch ✅ 30ms
Header Behavior On Retry.Attempt Header Starts At One ✅ 5ms
Header Behavior On Retry.Attempt Header Increments On Retry ✅ 10138ms
Header Behavior On Retry.Request Id Preserved On Retry ✅ 5135ms
Header Behavior On Retry.Different Requests Have Different Request Ids ✅ 2022ms
Header Behavior On Retry.Request Timestamp Changes On Retry ✅ 5134ms
Response Format Validation.Success Response Has Uuid Keyed Results ✅ 16ms
Response Format Validation.Success Response Has Ok For Each Event ✅ 27ms
Response Format Validation.Success No Retry After When All Ok ✅ 26ms
Response Format Validation.Success Retry After Present When Retry Events ✅ 128ms
Response Format Validation.Success No Retry After When Drop Only ✅ 26ms
Response Format Validation.Response Echoes Request Id ✅ 6ms
Retry Behavior.Retries On 408 ✅ 5132ms
Retry Behavior.Retries On 500 ✅ 5135ms
Retry Behavior.Retries On 503 ✅ 5135ms
Retry Behavior.Retries On 504 ✅ 5134ms
Retry Behavior.Retryable Errors Have Retry After ✅ 2132ms
Retry Behavior.Respects Retry After On Retryable Error ✅ 8133ms
Retry Behavior.Does Not Retry On 400 ✅ 2131ms
Retry Behavior.Does Not Retry On 401 ✅ 2131ms
Retry Behavior.Does Not Retry On 402 ✅ 2132ms
Retry Behavior.Does Not Retry On 413 ✅ 2132ms
Retry Behavior.Does Not Retry On 415 ✅ 2131ms
Retry Behavior.Non Retryable Errors Have No Retry After ✅ 2131ms
Retry Behavior.Implements Backoff ✅ 15143ms
Retry Behavior.Max Retries Respected ✅ 15136ms
Partial Batch Handling.Handles 200 Full Success ✅ 2009ms
Partial Batch Handling.Handles 200 With All Ok ✅ 3028ms
Partial Batch Handling.Does Not Retry Dropped Events ✅ 3027ms
Partial Batch Handling.Does Not Retry Limited Events ✅ 3031ms
Partial Batch Handling.Prunes Ok Events On Partial Retry ✅ 5132ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry ✅ 5134ms
Partial Batch Handling.Retries Only Retry Events From Partial ✅ 5136ms
Partial Batch Handling.Partial Retry Preserves Uuids ✅ 5133ms
Partial Batch Handling.Partial Retry Attempt Header Increments ✅ 5134ms
Partial Batch Handling.Partial Retry Request Id Preserved ✅ 5135ms
Partial Batch Handling.Respects Retry After On Partial ✅ 5134ms
Partial Batch Handling.Unknown Result Treated As Terminal ✅ 3029ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry ✅ 3032ms
Compression.Sends Gzip Content Encoding ✅ 15ms
Compression.No Content Encoding When Disabled ✅ 16ms
Compression.Compressed Body Is Decompressible ✅ 5ms
Error Handling.Does Not Retry On Unknown 4Xx ✅ 2131ms
Event Options.Cookieless Mode Override ✅ 5ms
Event Options.Disable Skew Correction Override ✅ 5ms
Event Options.Process Person Profile Override ✅ 15ms
Event Options.Product Tour Id Override ✅ 5ms
Event Options.Unset Options Omitted ✅ 4ms
Event Options.Options Override In Batch ✅ 7ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties ✅ 4ms
Geoip And Historical Migration.Historical Migration Set In Body ✅ 5ms
Geoip And Historical Migration.Historical Migration Absent By Default ✅ 5ms

Feature_Flags Tests

✅ 17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id ✅ 14ms
Request Payload.Flags Request Uses V2 Query Param ✅ 16ms
Request Payload.Flags Request Hits Flags Path Not Decide ✅ 15ms
Request Payload.Flags Request Omits Authorization Header ✅ 15ms
Request Payload.Token In Flags Body Matches Init ✅ 15ms
Request Payload.Groups Round Trip ✅ 15ms
Request Payload.Groups Default To Empty Object ✅ 15ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False ✅ 15ms
Request Payload.Disable Geoip Omitted Defaults To False ✅ 15ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key ✅ 15ms
Request Lifecycle.No Flags Request On Init Alone ✅ 2ms
Request Lifecycle.No Flags Request On Normal Capture ✅ 6ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests ✅ 27ms
Request Lifecycle.Mock Response Value Is Returned To Caller ✅ 15ms
Retry Behavior.Retries Flags On 502 ✅ 17ms
Retry Behavior.Retries Flags On 504 ✅ 16ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event ✅ 17ms

@dustinbyrne
dustinbyrne merged commit 6848dff into main Oct 21, 2026
34 checks passed
@dustinbyrne
dustinbyrne deleted the ci/synchronize-nested-core-minimums branch October 21, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants