Repository navigation
ci(release): synchronize nested module core minimums - #376
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Not approved — this change needs a human reviewer.
Re-adding the stamphog label gives the same result unless the changed files change.
stamphog can't approve this pull request automatically. Two gates refused it. The deny-list gate matched the infra/CI-CD category because the change edits .github/workflows/release.yml. The tier gate classified it as T2-never (35 lines across 3 files, two areas, CI), which is never eligible for automated approval.
The size and prerequisites gates passed, so splitting the PR won't change the outcome while the workflow change is included. The author should ask a human maintainer to review it.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✗ | matches: infra_cicd |
| size | ✓ | 14L, 1F substantive, 35L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✗ | classified as T2-never: T2-never (35L, 3F, two-areas, ci) |
| stamphog 2.6.0 | .stamphog/policy.yml @ unknown · reviewed head 581a0c8 |
posthog-go Compliance ReportDate: 2026-10-19 20:29:48 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
💡 Motivation and Context
The release workflow already tags core, OTel, and the MCP adapter with one shared version, but leaves the nested modules' core requirements unchanged. A module can therefore ship with a minimum that does not support its new core-dependent behavior, even though checkout tests pass through the local
replace.Synchronize both core minimums to the computed release version before the automated version-bump commit.
go mod editupdates the manifests without resolving the not-yet-published version. The existing commit and tagging steps then include those requirements in the release artifacts.Update the release guide and MCP adapter instructions to describe this policy. Consumers can still select a newer core version. This is release-tooling/documentation only and does not need a changeset or an SDK release to take effect.
Related: #375.
💚 How did you test it?
GOPROXY=off,GOSUMDB=off,GOTOOLCHAIN=local,GOWORK=off).1.35.2), minor (1.36.0), and prerelease (1.36.0-rc.1) cases update both requirements correctly; other dependencies, local replacements, and checksums remain unchanged. Repeating the step is idempotent.bash -n, ShellCheck, andgit diff --checkpass.No live release, tag creation, or publishing was exercised. SDK runtime code is unchanged.
📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi and checked by a fresh read-only reviewer. The change keeps the existing shared-version release model and adds dependency synchronization within release preparation. Validation exercised the workflow's synchronization commands offline; the complete publishing workflow was not run.