Repository navigation
feat(otel): add opt-in exception trace context - #374
pauldambra wants to merge 2 commits into
Conversation
Generated-By: PostHog Desktop Task-Id: 5681be44-4986-48db-b140-1bda88f75f96
There was a problem hiding this comment.
PostHog Review · Standard · reviewed 1e928fe: 1 Should fix.
This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.
posthog-go Compliance ReportDate: 2026-10-16 12:30:19 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
|
Note 🤖 Automated comment by QA Swarm — not written by a human Review: router passes, with a separate check of the public helper fix. Verdict: ✅ APPROVE (round 2 @ 8c375c9)No actionable findings remain in this review. The request trace override fault is fixed and has a regression test. Key findings
ConvergenceThe first router pass confirmed the existing PostHog Review finding. The fix reply records the commit and test evidence. Reviewer summaries
The API and proposed spec still need agreement before merge. This code review does not remove that hold. Previous rounds (1)round 1 @ 1e928fe - APPROVE WITH NITS: request trace overrides could be lost for enqueue-only clients; fixed in 8c375c9. Automated by QA Swarm — not a human review |
Generated-By: PostHog Desktop Task-Id: 5681be44-4986-48db-b140-1bda88f75f96
[Robot] Draft prepared with Codex.
💡 Motivation and Context
Developers need to find the trace for a captured exception. Existing Go exception events do not identify the active span.
posthogotel.EnqueueWithContextto the existing optional OpenTelemetry module. It adds trace IDs only to exception messages.context.Context, so callers pass that context.This is an API proposal and an explicit integration. Existing core enqueue and automatic panic capture do not gain trace IDs. This draft does not claim automatic conformance with the proposed exception trace contract. It waits for API and contract agreement before merge.
💚 How did you test it?
BeforeSendhook.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file. Added a minor changeset directly; the release workflow tags nested modules from the root version.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Codex (gpt-6) used the shell, Go, Git, and the GitHub CLI. Skills used: writing-tests, writing-code-comments, writing-user-facing-copy, and writing-pr-descriptions. The helper uses the existing optional module to keep OpenTelemetry out of the core SDK. Human review is required.
Created with PostHog Desktop