Repository navigation
chore!: make SDK-internal helpers non-public - #872
Open
turnipdabeets wants to merge 2 commits into
Open
turnipdabeets wants to merge 2 commits into
turnipdabeets wants to merge 2 commits into
Conversation
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
4 of 5 tasks
dustinbyrne
approved these changes
Oct 22, 2026
turnipdabeets
force-pushed
the
chore/v4-narrow-public-api
branch
from
October 23, 2026 15:47
66f5d4d to
937cc56
Compare
turnipdabeets
force-pushed
the
chore/v4-remove-deprecated
branch
from
October 23, 2026 15:47
48776ff to
2f486a0
Compare
4 of 6 tasks
turnipdabeets
force-pushed
the
chore/v4-remove-deprecated
branch
from
October 26, 2026 16:29
2f486a0 to
a41d9b9
Compare
turnipdabeets
force-pushed
the
chore/v4-narrow-public-api
branch
from
October 26, 2026 16:29
937cc56 to
97fba3d
Compare
turnipdabeets
force-pushed
the
chore/v4-remove-deprecated
branch
from
October 26, 2026 18:47
a41d9b9 to
caf64bd
Compare
Make internal the public declarations that no other module in this repo and no wrapper (Flutter, React Native, KMP) uses. LogLine and LogcatParser are Java, so they become package-private. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
sdk_compliance_adapter is a separate Gradle module, only included by its Dockerfile, and constructs GzipRequestInterceptor directly. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
turnipdabeets
force-pushed
the
chore/v4-narrow-public-api
branch
from
October 26, 2026 23:05
97fba3d to
011a635
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on the 4.0 integration PR #871. Merges into
chore/v4-remove-deprecated, notmain.💡 Motivation and Context
Shrinks the public API for 4.0 by making SDK-internal helpers non-public. Matches PostHog/posthog-ios#874.
These were public only by accident. No other module in this repo uses them, and neither do the Flutter, React Native (posthog-js plugin and replay plugin) or KMP wrappers, checked against each wrapper's latest
main:CustomHeadersInterceptor,PostHogPrintLoggerPropertyGroupDeserializer,PropertyValueDeserializerRRDocumentNode,RRDomContentLoadedEvent,RRLoadedEventpersonPropertiesContext(),findBestTranslationMatch(),PostHogPreferences.PUSH_SUBSCRIPTION_REJECTED,ThrowableCoercer.fromThrowableToPostHogProperties()Bitmap.isValid(),Bitmap.webpBase64()LogLine,LogcatParser(Java, so package-private)Most other
@PostHogInternaltypes can't becomeinternal: Kotlininternalis per module, and they're used byposthog-androidorposthog-server, or appear in a public signature (PostHogConfig,PostHogApi,PostHogReplayIntegration). The wrappers also usePostHogPreferences,PostHogSessionManager,PostHogSerializer, the RR replay types,base64andgetApplicationInfo, so those stay public.GzipRequestInterceptorstays public becausesdk_compliance_adapter(a separate module that only its Dockerfile includes) constructs it.💚 How did you test it?
./gradlew :posthog:test :posthog-server:test :posthog-server-openfeature:test :posthog-android:testReleaseUnitTest :posthog-android-surveys-compose:testReleaseUnitTestpass.apiDumpregenerated.sdk_compliance_adaptercompiles when included the way its Dockerfile does.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file (adds a line to.changeset/android-v4-major.md)🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Claude Opus 5.5) listed every public declaration in an internal package or marked
@PostHogInternal, searched the other modules and the wrapper repos for uses, and let the compiler reject candidates that a public signature still exposes (nine were reverted for that reason).🤖 Generated with Claude Code