Repository navigation
Only check disks in the table's storage policy - #16
Merged
Merged
Conversation
LocalDisks rejected any non-local disk in system.disks, so upload-freeze failed on servers with an ObjectStorage disk even when the source table never used it. Scope disk discovery to the table's storage policy. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
upload-freezefailed withClickHouse disk "s3disk" has unsupported type "ObjectStorage"on servers that have an object-storage disk, even when the source table's storage policy does not use it.freeze.LocalDisksvalidated every disk insystem.disks.Change
LocalDisksnow takes the database and table, and only returns disks in that table's storage policy (system.tables.storage_policy→system.storage_policies.disks). A table that is actually on S3 is still rejected.Callers updated:
upload-freeze: source tableVerification
go mod tidy,go test ./...pass./e2e/run.shpasses (e2e ClickHouse has only local disks, so the skip-unused-S3-disk case is not covered there)🤖 Generated with Claude Code