Repository navigation
chore(feature-flags): snapshot the 3.x Android flag pages - #471
Open
turnipdabeets wants to merge 2 commits into
Open
turnipdabeets wants to merge 2 commits into
turnipdabeets wants to merge 2 commits into
Conversation
The Android flag variants install posthog-android 3.x, but read the live flag code page and the Android flag install page, which move to 4.0 on release day. They now read 2026-11-04 snapshots of both pages. The flag code page is a group shared doc, so a variant's own shared_docs entry now replaces the group's one with the same file name. Every other variant still reads it live. Co-Authored-By: Claude Opus 5.5 <[email protected]>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
This was referenced Nov 5, 2026
turnipdabeets
marked this pull request as ready for review
November 5, 2026 23:03
#478) * chore(skills): snapshot the 3.x iOS flag, error tracking and logs pages posthog-ios 4.0 moves the iOS install snippets to SPM `from: "4.0.0"` and drops CocoaPods (posthog.com#21807, posthog#129618), and changes the iOS section of the flag code page. The iOS variants install 3.x, so they read copies taken while the pages still describe it. Co-Authored-By: Claude Opus 5.5 <[email protected]> * docs: name the logs snapshot's 3.59.3 pin in the README --------- Co-authored-by: Claude Opus 5.5 <[email protected]>
turnipdabeets
requested review from
JamesPatrickGill,
ablaszkiewicz and
hpouillot
November 5, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Android feature flag variants install posthog-android 3.x, but they read two pages live:
feature-flags/adding-feature-flag-code.md(a groupshared_docsentry) andfeature-flags/installation/android.md. When posthog-android 4.0 ships, PostHog/posthog.com#21808 changes the Android snippet on the first page toPostHog.onFeatureFlags { loaded -> … }, which 3.x doesn't have. The second page renders the in-app onboarding, which moves toprojectTokenandposthog-android:4.+. The next build after that would hand 3.x installs 4.0-only code.Stacked on #454, which adds the legacy snapshots and repo-file
docs_urls. Like #454, it must be released before those pages change.Changes
context/docs-snapshots/legacy/feature-flags/: copies of both pages, taken 2026-11-04 while they still describe 3.x (apiKey,posthog-android:3.+, theonFeatureFlagsconfig option). They sit in a subfolder so the install page keeps itsandroid.mdreference name next to the library page snapshot. The README lists them.shared_docsentry now replaces the group's entry that writes the same reference file, in place. Before, both were fetched and the later one overwrote the file. No variant declaresshared_docstoday, so nothing else changes.feature-flagsandintegration-v2/feature-flags-step: theandroidvariant reads both snapshots. All other variants still read the flag code page live.omnibus/instrument-feature-flags: reads the Android install page snapshot. It keeps the live flag code page, because that one skill covers every platform. The 4.0 Android snippet on that page has a note for 3.x readers.Not covered: iOS has the same problem with PostHog/posthog.com#21807. The iOS variants could use the same flag code page snapshot, with one
shared_docsline each, once someone checks the iOS install page.Test plan
pnpm test: 227 passed. New tests cover the in-place replacement and that both Android flag variants get the snapshot instead of the live page. The install page is added to the list of pages no config may fetch live.feature-flags-android,integration-v2-feature-flags-step-androidandomnibus-instrument-feature-flags. Both Android skills'adding-feature-flag-code.mdreference is byte-identical to the snapshot. The snapshots match the live pages today, so the output is unchanged until the pages move.LLM context
Written with Claude Code (Opus 5.5) at the request of the posthog-android maintainer.
🤖 Generated with Claude Code