Skip to content

fix: make column-order differences actionable - #243

Merged
orian merged 2 commits into
mainfrom
fix/mv-column-order-diagnostic
Sep 8, 2026
Merged

orian merged 2 commits into
mainfrom
fix/mv-column-order-diagnostic

Conversation

@orian

@orian orian commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • report materialized-view order-only changes as column_order with explicit old and new lists
  • preserve the existing unsafe recreate policy; no column-reordering behavior is introduced
  • add plan -ignore-column-order with the same semantics as diff
  • show the opt-out hint only in interactive text output, keeping redirected and JSON output clean
  • document the policy and structured field vocabulary

Tests

  • end-to-end diff coverage for text, JSON, and ignored order
  • end-to-end plan -dump coverage for default and ignored table/materialized-view order
  • unit coverage for plan option propagation, comparison rendering, unsafe reasons, and terminal-only hints
  • go test ./...
  • go test -race ./internal/... ./cmd/...
  • go vet ./...
  • go build ./...

Addresses #240 point 1 only. Point 2 remains intentionally unimplemented.
Closes #241.

@orian
orian merged commit 466b780 into main Sep 8, 2026
16 checks passed
@orian
orian deleted the fix/mv-column-order-diagnostic branch September 8, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plan: add -ignore-column-order, matching diff

1 participant