Repository navigation
feat(locate): add table column selection - #234
Merged
Merged
Conversation
orian
added a commit
that referenced
this pull request
Sep 7, 2026
## Summary - change table/column lookup to load and resolve models before searching them - compose every manifest role/environment stack, treat the ordered -layer list as one model, and load every dump file as an independent node model - load independent models through a bounded 32-worker pool while preserving deterministic result order, allowing all 30 nodes in a typical cluster to load concurrently - search final resolved table columns so inheritance, patches, modifications, overrides, and drops are reflected - return each matching manifest, layer, or dump model in text and JSON output and update the public documentation ## End-to-end coverage - run the CLI in a subprocess for the multi-table/multi-column report, empty-success behavior, and malformed-input failure - run the CLI in a subprocess against 30 real node dump files and verify all 30 resolved model references - use a worker barrier test to prove 30 loads start concurrently before any finishes and that results retain source order ## Verification - go test ./... (1360 tests) - go test -race ./internal/... ./cmd/... (1346 tests) - go vet ./... - go build ./... - gofmt -s -l . - git diff --check Follow-up to #234.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Closes #233