Conversation
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 2 to 4. - [Release notes](https://github.com/actions/attest-build-provenance/releases) - [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md) - [Commits](actions/attest-build-provenance@v2...v4) --- updated-dependencies: - dependency-name: actions/attest-build-provenance dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6 to 7. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v6...v7) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.2 to 3.1.4. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.2...v3.1.4) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
chore: back-merge 1.2.1 (main → dev)
…ctions/setup-node-7 ci: Bump actions/setup-node from 6 to 7
…i-3.1.4 ci: Bump fast-uri from 3.1.2 to 3.1.4
…ctions/attest-build-provenance-4 ci: Bump actions/attest-build-provenance from 2 to 4
…tion Obsidian's plugin CSS check maps the entire `text-decoration` family onto a single caniuse feature that Chrome supports only partially, so the longhands 1.2.1 switched to warn exactly like the shorthand did. Use a dotted `border-bottom` (plus `padding-bottom` for the offset) instead — same cue, CSS1 properties nothing has ever qualified. `scripts/validate.mjs` now fails on any `text-decoration*` declaration in styles.css: the reviewer's check runs on their side only, which is how the same warning came back a second time. Release 1.2.2. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_019Xs98arTAdcat1h9pkz7Vy
fix: draw the inert footnote underline with a border, not text-decoration (1.2.2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
dev→mainreleases 1.2.2: the workflow readsversionfrommanifest.jsonand pushes the bare1.2.2tag with attestedmain.js/styles.css.What's in it
The fix (#37) — Obsidian's 1.2.1 plugin review left one warning:
Those lines were the
text-decoration-line/text-decoration-stylelonghands 1.2.1 switched to, on the assumption that only the multi-value shorthand was flagged. The reviewer's check actually maps the entiretext-decorationfamily onto one caniuse feature Chrome supports only partially, so no spelling of it passes. The inert footnote marker's dotted underline is now aborder-bottom: 1px dotted currentColorwithpadding-bottom: 1pxfor the offset — same cue, CSS1 properties only. No behaviour change.Recurrence prevention —
scripts/validate.mjsfails the build on anytext-decoration*declaration instyles.css. The reviewer's CSS check runs on their side only, which is how the same warning came back twice; the local gate now carries the rule.Also landed on
devsince 1.2.1 — CI/dev-only dependency bumps, no runtime effect:actions/attest-build-provenance2→4 (#27),actions/setup-node6→7 (#29),fast-uri3.1.2→3.1.4 (#30). Not changelogged — none are user-facing.Version lockstep
manifest.json1.2.2 ·versions.json"1.2.2": "1.6.6"·CHANGELOG.mddated section.minAppVersionunchanged.Gate
npm ci·npm run lint·npm run build·node --check main.js·node scripts/validate.mjs— all green on mergeddev, including with the bumped lockfile.Not verified
The dotted
border-bottomwas not eyeballed in a real vault. On an inline<a>a bottom border sits at the descender line rather than at the underline position;padding-bottom: 1pxaccounts for that. Worth a look at an unresolved footnote marker in a full-screen table.🤖 Generated with Claude Code
https://claude.ai/code/session_019Xs98arTAdcat1h9pkz7Vy