Skip to content

Refresh selected same-size files and configure upload exclusions - #16

Merged
v-positronic merged 9 commits into
Positronic-Robotics:mainfrom
sasha-s:codex/e2e-metadata-overwrite-r18
Oct 7, 2026
Merged

v-positronic merged 9 commits into
Positronic-Robotics:mainfrom
sasha-s:codex/e2e-metadata-overwrite-r18

Conversation

@sasha-s

@sasha-s sasha-s commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Selected overwrite patterns previously did not refresh a same-size single-file transfer. A root file has an empty relative path, and matching it as "." rejected both wildcard and exact local-basename patterns. The diff matcher now uses the local source basename for that case, in both planning and execution. Directory-relative matching and remote key construction keep their existing behavior.

This also retains the reviewed filename-selected overwrite and directional upload-exclusion API. Omitted or empty overwrite selections preserve size-only behavior. Download filtering and deletion settings keep their existing behavior.

Verification at d5fae5039d8e4cfd661065706a2d2a1168717ade:

  • All 181 tests pass with zero failures, errors or skips on frozen source. The preceding actual-transport control fails four selected same-size transfers, while eight default and nonmatching controls pass.
  • The 12 upload/sync cases cover omitted, empty, wildcard, exact local basename, renamed remote basename and nonmatching directory-qualified patterns. They verify stored/read-back payloads and preserve remote-only siblings. Existing directory compatibility cases remain in the full suite.
  • Applicable changed-file and configuration hooks, exact-range checks and SSH signatures pass. A broad all-files hook attempt found existing formatting drift and was restored; its overlapping test run remains rejected evidence.
  • Root own review and independent Sol review are clear. Sol independently exercises 14 API cases and a failing original-source control. Independent Opus source review is clear on this exact commit. The S3 adapter is in memory, so this is not live AWS evidence.

This dependency supports Platform recording proof #767, which will pin the published immutable repair and run the complete affected producer suite. Source publication does not establish combined E2E success or merge readiness.

The upstream Claude review still has its author-permission gate. The fork push cannot change that base-workflow authority requirement. No deployment or main merge is part of this publication.

@sasha-s

sasha-s commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator Author

At current published head d5fae5039d8e4cfd661065706a2d2a1168717ade, the unit-test build now passes after a maintainer-triggered rerun. Build approval is no longer an open gate.

The latest Claude review attempt still stops before source review. Although its triggering actor is a maintainer, the action checks the original PR actor and reports Permission level retrieved: read and Actor does not have write permissions to the repository. Repeating the same rerun does not change that actor. A maintainer must choose an eligible new event, access grant, or explicit trust policy in the base workflow. No permission or trust bypass has been added.

The review-event workflow is skipped. Local source verification remains separate from the open hosted review gate.

@v-positronic
v-positronic merged commit ddebabd into Positronic-Robotics:main Oct 7, 2026
2 of 4 checks passed
@sasha-s

sasha-s commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Independent shipping verification: PASS+NOTES for d5fae5039d8e4cfd661065706a2d2a1168717ade against e7651c884519f18497511f587712bfe173dae46d. Stable patch-id def07a965c31a0a482520cdfa6df904b63eb0e92.

I checked the source diff and ran Python 3.11.15 with the head's locked dev dependencies in a separate clean checkout. All 181 tests pass. A separate collection matches all 181 executed JUnit cases, with zero skips, missing cases or extra cases. The tracked source hashes and modes stayed identical before and after every probe. GitHub's published source bytes match the tested module, SHA-256 d26f8ecc62c9eb5a7dfc51db9b3a904e5cf4f42dd270560e327ad8ca867f0174.

Two independent public API probes distinguish this head from its parent. Selected same-size single-file overwrite replaces stale bytes at a renamed remote key, agrees with the planner and downloads the new bytes. Default size-only behavior remains unchanged. Sync downloads baseline unfinished markers while withholding new markers, uploads recording data, then publishes markers in its final one-shot upload. Both probes preserve foreign remote objects and fail on the parent for the expected missing behavior. These use an in-memory S3 boundary and make no AWS calls.

The first macOS suite run had two pre-existing /var versus /private/var path assertion failures. Rerunning with TMPDIR=/private/tmp passes all 181 cases without changing source. I also corrected the independent probe's path comparison to use the planner's canonical path, retaining the original failed run.

Hosted build is green. The maintainer approved this exact head. There are no inline source review threads. The failed Claude review exits before source review because the original actor sasha-s has read permission. Its review-event job is skipped. This records an action permission failure before source review. The current account lacks push, maintain and admin permission; I performed no merge, bypass or trust-setting change.

The fresh final read reports that the PR merged externally at 2026-10-07T17:53:39Z as ddebabd2f3c2c207f47012804be0ebbb7c913cbd. I verified that the merged module bytes match the exact tested head.

Evidence receipts passed the executable binding checker. Receipt SHA-256 values:

  • overwrite-head-r2.receipt.json: a2824a383c4faff854afeb0a2d42cb0622ae2914df8793ed016f6d19997d5108
  • markers-head-r2.receipt.json: 962017e3295aa57d4a5de501de6bed935f5c7cb33bf8893d2f268768c31ea218
  • full-head-canonical.receipt.json: 02ea750d32be9565726bf765e5df23c00fb51427fcd9cdf2639593254001cc48

Build: https://github.com/Positronic-Robotics/pos3/actions/runs/37588482683/job/112921485995
Review permission failure: https://github.com/Positronic-Robotics/pos3/actions/runs/37588478723/job/112921833500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants