This repository was archived by the owner on Oct 9, 2026. It is now read-only.
Repository navigation
Fix FTP access to launch age configuration - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app created
/data/opennowwith mode0700, preventing FTP processes running as another user from uploading the required launch-age configuration.Create
/data/opennow/configfor FTP uploads and repair directory permissions on startup, including existing installations. Keep the parent directory writable only by its owner so saved account files cannot be planted or replaced by other users. Read the age fromconfig/launch-age.txt, retaining the original path as a fallback only when the new file is absent. Reject symlinks and use bounded, nonblocking reads so malformed files and FIFOs do not hang the worker. Update installation instructions.Validation:
bash tools/test-port.shpassed. After the security revisions, the ASan/UBSan persistence test passed again, covering directory migration, restrictive umasks, preserved login contents and permissions, legacy fallback, invalid ages, symlinks and FIFOs. PS5/FTP validation and a native build remain pending; this PR does not publish a console package.Fixes #1.