Repository navigation
Show game names, versions, DLC, mods and artwork in Emulation - #57
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Claude review: ✅ Code review: no findingsReviewed full PR ( No findings. Files reviewedScope: the PR's own diff against its base Source, tests and docs (read in full at the PR head, including the relevant callers):
Generated artifacts (checked metadata and hash consistency only; binaries are covered by the isolated package checks):
Bottom line: ✅ Wait for the combined CI verdictCode review complete; host checks pending. This marker reflects the code review only, not merge readiness. To fix before merge: nothing. Notes (no action needed):
Not verified: PS5 runtime acceptance of this exact build (manager ELF and native eboot). Two things have no host fixture: the encrypted (AES-CTR, key-area) Control RomFS path that retail games use, and Eden's cover filename hashing ( |
|
✅ Ready to merge. Claude's review of |
* Refresh Explore on launch and update expired rankings automatically (#50) * Refresh Explore on launch and revalidate expired rankings * Refresh packaged sources for Explore changes --------- Co-authored-by: Jordan Lahmi <[email protected]> * Unify game preparation, server FPKG conversion and Activity (#49) * Unify game preparation and Activity across PS5 and server * Limit FPKG magnet hints to decoded display names * Ignore non-owning attempts when removing adopted import tracking --------- Co-authored-by: Portablelle <[email protected]> * Keep review and host checks within the 4 GiB CI memory budget (#52) Co-authored-by: Portablelle <[email protected]> * Add standalone Switch emulation and verified game imports (#51) * Add standalone Switch emulation, verified imports and full configuration * Update package contract tests for split corresponding sources * Run Switch regressions in CI and use stable names for native action tests --------- Co-authored-by: Portablelle <[email protected]> * Fix Switch patch and DLC verification and bundled imports (#53) Co-authored-by: Portablelle <[email protected]> * Add per-game UltraCam configuration for BOTW (#54) * Add per-game UltraCam configuration for BOTW * Keep native updater fixtures aligned with the current release --------- Co-authored-by: Portablelle <[email protected]> * Release Botty+ 2.0.0 with standalone Switch emulation * Document the global Switch Config tab * Clarify Switch controls and PS5 preparation limits * Show game names, versions, DLC, mods and artwork in Emulation (#57) * Show Switch library names, versions, DLC, mods and artwork * Refresh emulation library release packages and corresponding sources * Synchronize display caches and aggregate title relationships once * Decode Switch artwork outside the service-wide lock --------- Co-authored-by: Portablelle <[email protected]> * Fix ZIP worker stack usage and run source archive tests in CI --------- Co-authored-by: Jordan Lahmi <[email protected]> Co-authored-by: Portablelle <[email protected]>
The Emulation library now identifies Switch games from their Control/NACP metadata and shows cover art, base/update versions, associated DLC and named mod switches. The selected game panel includes its title ID and filename, with direct launch and existing configuration actions.
Display metadata uses bounded reads and synchronized, identity-based caches. Title relationships are aggregated once per inventory. Import verification remains separate, unknown metadata stays visible, and update/DLC presence and saved mod switches are distinguished from the engine's compatibility decisions. Artwork supports existing emulator covers and embedded icons, with input bounds and truncated-TGA regression coverage.
Includes corresponding manager/native packages and source archives.
Validation on the dedicated Linux build server:
python3 scripts/botty-packages.py --check.Earlier console acceptance confirmed Mario Kart 8 Deluxe, base 1.0.0, update 3.0.5, one associated DLC and artwork through the installed manager. UI layout was inspected in a rendered preview.
This PR targets
codex/release-2.0.0: the remotemaincurrently predates the Switch/release commits, while this branch provides the required baseline and keeps this diff scoped to the library improvements.