Repository navigation
Add per-game UltraCam configuration for BOTW - #54
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Claude review: Code review: no findingsReviewed commits 05c6e21..aa7a188 (full PR reviewed previously at No findings. Files reviewedIncremental (
Previously reviewed at Bottom line: Wait for the combined CI verdictTo fix before merge: nothing. Notes (no action needed):
Not verified: PS5 runtime acceptance (the PR reports a manual BOTW 1.6.0 hardware run, which host review can't confirm). Also not verified: compilation of the patched engine sources and whether the shipped |
|
✅ Ready to merge. Claude's review of |
* Refresh Explore on launch and update expired rankings automatically (#50) * Refresh Explore on launch and revalidate expired rankings * Refresh packaged sources for Explore changes --------- Co-authored-by: Jordan Lahmi <[email protected]> * Unify game preparation, server FPKG conversion and Activity (#49) * Unify game preparation and Activity across PS5 and server * Limit FPKG magnet hints to decoded display names * Ignore non-owning attempts when removing adopted import tracking --------- Co-authored-by: Portablelle <[email protected]> * Keep review and host checks within the 4 GiB CI memory budget (#52) Co-authored-by: Portablelle <[email protected]> * Add standalone Switch emulation and verified game imports (#51) * Add standalone Switch emulation, verified imports and full configuration * Update package contract tests for split corresponding sources * Run Switch regressions in CI and use stable names for native action tests --------- Co-authored-by: Portablelle <[email protected]> * Fix Switch patch and DLC verification and bundled imports (#53) Co-authored-by: Portablelle <[email protected]> * Add per-game UltraCam configuration for BOTW (#54) * Add per-game UltraCam configuration for BOTW * Keep native updater fixtures aligned with the current release --------- Co-authored-by: Portablelle <[email protected]> * Release Botty+ 2.0.0 with standalone Switch emulation * Document the global Switch Config tab * Clarify Switch controls and PS5 preparation limits * Show game names, versions, DLC, mods and artwork in Emulation (#57) * Show Switch library names, versions, DLC, mods and artwork * Refresh emulation library release packages and corresponding sources * Synchronize display caches and aggregate title relationships once * Decode Switch artwork outside the service-wide lock --------- Co-authored-by: Portablelle <[email protected]> * Fix ZIP worker stack usage and run source archive tests in CI --------- Co-authored-by: Jordan Lahmi <[email protected]> Co-authored-by: Portablelle <[email protected]>
Botty+ Config now offers per-game UltraCam 1.0.1 controls for Breath of the Wild 1.6.0: FPS target, internal resolution, quality, draw distance, FOV, camera and benchmark settings. The optional mod is disabled by default, bundled with its CC-BY-NC attribution and license, and installed into a managed game-specific folder.
Activation verifies payload hashes and the selected update's Control/NACP version and Program patch against the actual base ROM. Disabled-update overrides fail closed. Saving preserves other mods and global video preferences, refuses edited or unmanaged files, and restores the previous state if activation fails. Botty+ 1.12.2 and manager 1.10.4 include the complete runtime inventory and matching corresponding-source parts.
Validation: native UI, manager and emulator built on the dedicated server; adapter integrity/rollback/dependency regressions; actual renderer controls and persistence; native transaction, update, idle-gate and installation lifecycle tests; pinned patch applied to a clean upstream checkout; release package verification. Hardware test on PS5: BOTW 1.6.0 launches with UltraCam active and Link is controllable. With UltraCam at 1152p / target 60, the observed gameplay average was about 43 FPS with engine render scale 2×, then 47.02 FPS over 60.13 seconds at 1× (five-second windows: 39.79–53.23 FPS). These were manual gameplay samples, not a deterministic benchmark; 60 FPS is not sustained. The user chose to keep 1152p / 1×. Global video settings remain separate.
Portal companion: Portablelle/Portal-Plus#30 recognizes the previous manager during staging; merge it before publishing this release through Portal.
The manager also explicitly sets its updater identity to 1.10.4; the previous default of 1.7.0 caused combined-update checks to reject the running executable. Native updater fixtures use the generated current release version so service-only updates remain covered when the app version changes; older-native rejection is asserted separately.