Run CI on GitHub Actions - #4407
Draft
ferblape wants to merge 2 commits into
Draft
Conversation
Ports the CircleCI pipeline to GitHub Actions with the same partitioning: one build job that compiles assets, 21 test legs (16 Gobierto modules plus others and engines, with admin/people/plans split in two), and a production deploy gated on master. `circleci tests run --split-by=timings` has no GitHub Actions equivalent, so shard balancing is done here: `script/ci/collect_timings` sums the per-file runtimes out of the JUnit XML that minitest-ci already writes, master stores the result in the Actions cache, and `script/ci/split_tests` bin-packs each module's files across its shards. Without recorded timings it falls back to file size, which self-corrects after one master build. `.circleci/config.yml` stays in place until GitHub Actions has been green for a few days. Requires these repository settings before the workflow can pass: CUSTOM_ENGINE_NAME_1 (variable), CUSTOM_ENGINE_DEPLOY_KEY, DEPLOY_BOT_TOKEN and GOBIERTO_PRODUCTION_DEPLOY_URL (secrets). Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
ferblape
force-pushed
the
ferblape/circleci-to-github-actions
branch
from
September 10, 2026 08:57
0abb401 to
0db5e20
Compare
Both are set as CircleCI project environment variables and were missed when the pipeline was ported. The custom engine setup scripts resolve the checkout as `$DEV_DIR/gobierto` and print a hint and exit 0 when DEV_DIR is unset, so without it the engines were silently never installed. RETRY_FAILING_TEST turns on Minitest::Retry (test/test_helper.rb), so leaving it unset would have made flaky tests fail runs that CircleCI retries. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✌️ What does this PR do?
Ports the CircleCI pipeline to GitHub Actions with the same partitioning — one
buildjob that compiles assets, 21 test legs (16 Gobierto modules plusothersandengines, withadmin/people/planssplit in two) and a production deploy gated onmaster. Sincecircleci tests run --split-by=timingshas no GitHub Actions equivalent, shard balancing now lives in the repo:script/ci/collect_timingssums per-file runtimes from the JUnit XML thatminitest-cialready writes,masterstores the result in the Actions cache, andscript/ci/split_testsbin-packs each module's files across its shards (falling back to file size until the firstmasterbuild lands)..circleci/config.ymlis intentionally left in place so both CIs run in parallel for a few days, and is removed in a follow-up PR.This cannot go green until these repository settings exist:
CUSTOM_ENGINE_NAME_1(variable) and theCUSTOM_ENGINE_DEPLOY_KEY,DEPLOY_BOT_TOKENandGOBIERTO_PRODUCTION_DEPLOY_URLsecrets, plus anything else currently set in CircleCI project settings that I can't see from the repo. Note the deploy key must reach every private reposcript/custom_engines_ci_setupclones, not just the first engine.🔍 How should this be manually tested?
tests_*job must have a counterpart with a comparableN runs.masterbuild, confirm thecollect timingsjob saved a cache entry and that a subsequent branch build has its twoadminshards within roughly 20% of each other.production deployis skipped on branches and appears onmaster.Verified locally:
actionlintis clean, and the 21 legs cover 445 test files with zero overlap between them. Nothing runtime (services, engine clone, seeds, Chrome) has been exercised yet.👀 Screenshots
N/A — CI configuration only, no user-facing change.
.env.example?config/application.yml?config/secrets.yml?No application configuration changes. The new values are CI-only credentials that live in GitHub repository settings (see above), mirroring what CircleCI holds today, so no Ansible role update is needed.
📖 Does this PR require updating the documentation?
Known gap, ported as-is rather than fixed here:
test/models/gobierto_module_settings_test.rbandtest/lib/i18n/gobierto_backend_test.rbrun in no job today — theothersfilter-not -path '*gobierto_*'drops them by filename and no module pattern claims them. Widening it to-not -path '*/gobierto_*/*'would double-run 12test/pub_sub/subscribers/gobierto_*files, so the real fix ("everything minus the union of the module legs") belongs in its own PR to keep this one a faithful port.