fix(client): extend session-key relayer timeout - #283
Open
kartojal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the relayer read timeout to five minutes for sync and async session-key authorization and revocation submissions. Transaction and registry polling timeouts remain unchanged.
Tests:
uv run pytest tests/unit/test_session_key_authorization.pyNote
Low Risk
Scoped timeout override for session-key relayer POSTs only; no auth or signing logic changes.
Overview
Session-key authorize and revoke submissions can block on the relayer while it validates, simulates, persists, and broadcasts, so the default 10s HTTP read timeout was too short.
This PR passes a dedicated
httpx.Timeout(300s read) intopost_jsonfor both async and sync_post_session_key_operationhelpers. Connect, write, and pool limits stay modest; transaction and registry polling still use existing relayer poll settings.Reviewed by Cursor Bugbot for commit d4726ff. Bugbot is set up for automated code reviews on this repo. Configure here.