Cut API v1 simulations over to the Cloud Run entrypoint - #3784
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3784 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 75 75
Lines 4448 4448
Branches 825 825
=======================================
Hits 3596 3596
Misses 622 622
Partials 230 230 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anth-volk
marked this pull request as ready for review
July 31, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3783
Summary
Why
PR #3776 introduced the selectable Cloud Run Simulation Entrypoint while keeping API v1 on direct Modal. The canonical Cloud Run path has now passed health, readiness, authentication, comparison, one-year budget-window, unchanged-ID cross-polling, request-ID/log correlation, backend-identity, and paired runtime qualification. Stage 5 now needs a small, independently reviewed commit to trigger the actual release without coupling the cutover to another client refactor.
Impact
This PR does not change application code or the public API contract. Immediately before merge, both existing API v1 GitHub environment variables must be changed from
old_gateway_directtocloud_run_simulation_entrypoint. The already-qualified canonical URL remains environment-scoped configuration, and the direct Modal URL remains configured for rollback.Merging then runs the existing release sequence: the complete staging calculation, economy, and budget-window suite must pass before production begins; production deploys automatically and assigns stable API v1 traffic to the exact tested revision.
Migration scope
Validation
make format(205 files left unchanged)python scripts/export_migration_contracts.py(generated artifacts unchanged)python scripts/run_quality_guards.py(migration-contracts: passed)python -m pytest tests/unit/test_migration_contract_artifacts.py -q.github/scripts/check_changelog_fragment.shgit diff --checkPre-merge gate
Keep this PR in draft until both GitHub environment selectors are set to
cloud_run_simulation_entrypointand read back immediately before merge. The URL secrets and direct-Modal rollback variable must also still exist.