Propagate PolicyEngine request IDs to the simulation service - #3782
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3782 +/- ##
==========================================
+ Coverage 80.71% 80.84% +0.13%
==========================================
Files 74 75 +1
Lines 4422 4448 +26
Branches 822 825 +3
==========================================
+ Hits 3569 3596 +27
+ Misses 623 622 -1
Partials 230 230 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3781
Summary
X-PolicyEngine-Request-IdRoot cause
API v1 used
X-Request-ID, while the simulation observability stack readsX-PolicyEngine-Request-Id. Flask and ASGI also had separate request-ID handling, and the shared simulation client did not forward request-scoped correlation metadata.Impact
Synchronous API v1, Simulation Entrypoint, and Modal gateway requests can now share one observability-supported request ID. Job and batch IDs remain unchanged for asynchronous execution correlation. This PR does not change routing, URLs, authentication, secrets, workflows, or API schemas.
Tests