Repository navigation
Undefined GCV in an if-global-variable condition is info, not an error - #124
Merged
Merged
Conversation
The engine reads an undefined GCV in <if-global-variable> as having no value (not-available is true, equal is false) and nothing fails. available / not-available tests are no longer reported; other ops are the new info gcv-undefined-condition. A GCV that is also substituted stays gcv-undefined. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcv-undefinedcounted<if-global-variable>conditions as errors. The engine reads an undefined GCV in a condition as having no value:not-availableis true andequalis false. Nothing fails. Packages use this to test GCVs that another package may define. For example, the SCIM driver's ReformatMembersAndGroups testsdrv.entitlement.Groupas "not-available or false".availableornot-availabletest is no longer reported.gcv-undefined-condition, because the outcome of that test never changes.token-global-variable,~name~) is stillgcv-undefined(E).docs/validation.md and CHANGELOG are updated. New tests are in ValidatorTest. The full suite passes: 1050 tests, 0 failures.
Checked on the edir3 tree: the 2 MITLL-Druva errors are now 2 infos, and validate reports 0 errors.
🤖 Generated with Claude Code