Repository navigation
Write only the package stamps that differ on a changed packaged object - #122
Merged
Merged
Conversation
A deploy that changed a packaged driver resource (here, the AD driver's NOVLADDCFG-GCVs after a one-value GCV override) planned the aux class and every package stamp again although the vault had the same values: five steps where one was needed. The plan now compares the stamps with the vault object's, writes only those that differ, and adds DirXML-PkgItemAux only when the vault object has no stamps, as it already did for Identity Applications objects. A customized object with no recorded checksum still gets a content-derived one. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On edir3 today, a deploy that changed two values in the AD driver's
NOVLADDCFG-GCVs, through edir3's overrides, planned five steps for that object:The deploy's own snapshot shows the vault already had the aux class and the same three values (
5DRKWAWH_…;com.netiqcorporation.novladdcfg;2.5.2…,IATDQ18S_201009040020200763,4234957497). They read the same after the deploy. So nothing changed, but the plan suggested it would change package stamps on a production deploy.The cause: for
ARTIFACT_CHANGED,PlanaddedAUX_CLASSand aMODIFYfor every stamp whenever the tree's artifact had stamps, without looking at the vault's. Identity Applications objects already compared them (parts.contains("stamps")andliveStamps).What changes
Plan.changedStamps).DirXML-pkgInitialStateisn't in the vault's model, so it is still written when the tree has a baseline, as before.!VaultMapping.isStamped(was)).package-stamps), and stripping.Tests
PlanTest.changedPackagedObjectDoesNotRewriteTheVaultsStamps: same stamps on both sides and edited content give noAUX_CLASSand noDirXML-pkg*step, only the content.PlanTest.changedPackagedObjectWritesOnlyTheStampThatDiffers: a different checksum gives onlyDirXML-pkgChecksumand noAUX_CLASS.Plan.javaand pass with the fix. The existing customized-checksum tests pass unchanged.DirXML-ConfigValues, plus the restart. Nothing was written.🤖 Generated with Claude Code