Repository navigation
Apply model meta options as per-field overrides - #281
Merged
Merged
Conversation
FlowOptionsOverride.get_options replaced the accumulated options with model.meta.options instead of applying only the fields it sets, as the docstring and the other option layers do. Setting a single field such as cacheable in a model's meta therefore discarded the globally configured evaluator, log level, and any options given to the Flow.call decorator, and the model fell back to the default logging evaluator. Among other effects, its calls lost graph evaluator node reuse, so a dependency marked uncacheable ran twice when its parent called it again. Signed-off-by: Tim Paine <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 93.86% 93.87%
=======================================
Files 202 202
Lines 22433 22447 +14
Branches 1455 1455
=======================================
+ Hits 21057 21071 +14
Misses 1091 1091
Partials 285 285 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Test Results 1 files ±0 1 suites ±0 1m 59s ⏱️ -26s Results for commit ae5ac10. ± Comparison against base commit 50befff. This pull request skips 4 and un-skips 1 tests.♻️ This comment has been updated with latest results. |
ptomecek
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlowOptionsOverride.get_options replaced the accumulated options with model.meta.options instead of applying only the fields it sets, as the docstring and the other option layers do. Setting a single field such as cacheable in a model's meta therefore discarded the globally configured evaluator, log level, and any options given to the Flow.call decorator, and the model fell back to the default logging evaluator. Among other effects, its calls lost graph evaluator node reuse, so a dependency marked uncacheable ran twice when its parent called it again.