Skip to content

Apply model meta options as per-field overrides - #281

Merged
timkpaine merged 1 commit into
mainfrom
tkp/meta-options-merge
Oct 16, 2026
Merged

timkpaine merged 1 commit into
mainfrom
tkp/meta-options-merge

Conversation

@timkpaine

Copy link
Copy Markdown
Member

FlowOptionsOverride.get_options replaced the accumulated options with model.meta.options instead of applying only the fields it sets, as the docstring and the other option layers do. Setting a single field such as cacheable in a model's meta therefore discarded the globally configured evaluator, log level, and any options given to the Flow.call decorator, and the model fell back to the default logging evaluator. Among other effects, its calls lost graph evaluator node reuse, so a dependency marked uncacheable ran twice when its parent called it again.

FlowOptionsOverride.get_options replaced the accumulated options with model.meta.options instead of applying only the fields it sets, as the docstring and the other option layers do. Setting a single field such as cacheable in a model's meta therefore discarded the globally configured evaluator, log level, and any options given to the Flow.call decorator, and the model fell back to the default logging evaluator. Among other effects, its calls lost graph evaluator node reuse, so a dependency marked uncacheable ran twice when its parent called it again.

Signed-off-by: Tim Paine <[email protected]>
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.87%. Comparing base (50befff) to head (ae5ac10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   93.86%   93.87%           
=======================================
  Files         202      202           
  Lines       22433    22447   +14     
  Branches     1455     1455           
=======================================
+ Hits        21057    21071   +14     
  Misses       1091     1091           
  Partials      285      285           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    1 files  ±0      1 suites  ±0   1m 59s ⏱️ -26s
1 556 tests +2  1 551 ✅  - 1  5 💤 +3  0 ❌ ±0 
1 622 runs  +2  1 617 ✅  - 1  5 💤 +3  0 ❌ ±0 

Results for commit ae5ac10. ± Comparison against base commit 50befff.

This pull request skips 4 and un-skips 1 tests.
ccflow.tests.enums.test_pydantic ‑ test_json_schema_csp
ccflow.tests.examples.test_calculator.TestCalculatorCli ‑ test_cli
ccflow.tests.examples.test_etl.TestEtl ‑ test_cli
ccflow.tests.utils.test_tokenize.TestAdversarialFixes ‑ test_function_docstring_still_stripped
ccflow.tests.enums.test_pydantic ‑ test_json_schema_no_csp

♻️ This comment has been updated with latest results.

@timkpaine
timkpaine merged commit c7ae99c into main Oct 16, 2026
20 checks passed
@timkpaine
timkpaine deleted the tkp/meta-options-merge branch October 16, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants