Skip to content

Use IntEnum for ccflow.Enum with csp 0.19 or newer - #280

Merged
timkpaine merged 3 commits into
mainfrom
tkp/intenum-enums
Oct 15, 2026
Merged

timkpaine merged 3 commits into
mainfrom
tkp/intenum-enums

Conversation

@timkpaine

@timkpaine timkpaine commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Also remove ruff noqa

csp 0.19 accepts any IntEnum as a native enum type. When the installed csp is at least 0.19, which is read from package metadata, base ccflow.Enum on an IntEnum that matches csp.Enum instead of importing csp, so importing ccflow no longer imports csp.

Signed-off-by: Tim Paine <[email protected]>
polars 2 does not preserve left frame row order in joins, so compare join results after sorting by the join key.

Signed-off-by: Tim Paine <[email protected]>
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    1 files  ±0      1 suites  ±0   1m 42s ⏱️ - 1m 14s
1 462 tests +1  1 460 ✅ +1  2 💤 ±0  0 ❌ ±0 
1 468 runs  +1  1 466 ✅ +1  2 💤 ±0  0 ❌ ±0 

Results for commit cedfc10. ± Comparison against base commit 70df911.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.04478% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.76%. Comparing base (70df911) to head (cedfc10).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ccflow/enums.py 85.71% 3 Missing and 2 partials ⚠️
ccflow/tests/enums/test_enums.py 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   93.79%   93.76%   -0.03%     
==========================================
  Files         190      190              
  Lines       21552    21597      +45     
  Branches     1413     1415       +2     
==========================================
+ Hits        20215    20251      +36     
- Misses       1062     1068       +6     
- Partials      275      278       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timkpaine
timkpaine merged commit 50befff into main Oct 15, 2026
18 of 20 checks passed
@timkpaine
timkpaine deleted the tkp/intenum-enums branch October 15, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants