Skip to content

Issue 51 - release GIL while calling ndiCommand #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MattClarkson wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −1
Open

Issue 51 - release GIL while calling ndiCommand #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c3e51b
Release GIL between calls to ndiCommand.
MattClarkson Aug 18, 2026
ae25f21
Decreaase reference count on initial and remainder variables, as per …
MattClarkson Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ndicapimodule.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,11 +752,20 @@ static PyObject* Py_ndiCommand(PyObject* module, PyObject* args)
return NULL;
}

result = ndiCommand(pol, "%s", PyString_AsString(newstring));
const char* cmd_cstr = PyString_AsString(newstring);
// Assumes caller manages threads.
Py_BEGIN_ALLOW_THREADS
result = ndiCommand(pol, "%s", cmd_cstr);
Py_END_ALLOW_THREADS
}
else
{
Py_DECREF(initial);

@adamrankin adamrankin Aug 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not my expertise, but why are these two reference decreases repeated? Is this a separate bug being fixed?

@MattClarkson MattClarkson Aug 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to be honest and say it was suggested by AI as a separate bug, so I left it in there. I don't really know how to test it in a reasonable time frame? Is there a simple test harness, where we could output the ref count while tracking?

Py_DECREF(remainder);
// Assumes caller manages threads.
Py_BEGIN_ALLOW_THREADS
result = ndiCommand(pol, NULL);
Py_END_ALLOW_THREADS
}

if (newstring != NULL)
Expand Down