Repository navigation
feature/Plugins-hook-revendor · L-261023-f21e88 - #149
Merged
Merged
Conversation
Re-vendor check.mjs from the pipelex-sdk commit whose hook reads an invalid verdict's errors[] as MTHDS problem items, so a block reason built without the server's Markdown names each item by its code, its sentence and its location, with its suggested fix beneath it, and no longer reads validation_errors[]. The build propagates the bundle to every target. The strict expected failure that held the gap is removed, and its test now passes outright. The hook docs, the decision log and the changelog describe the new reading. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Uzyvwk5dEQLz1LibAnaoNk
The test that the reason the hook builds names each problem item passed trivially, because every item's sentence already named its pipe. The fixture's sentences now name neither the pipe nor the file, each item carries a suggested fix, and the test holds the whole reason to the lines the bundle renders: each item's code, sentence, pipe and file, with its suggested fix beneath it. A new test sends entries the bundle cannot read beside ones it can, and holds the reason to what docs/hooks.md describes: an entry that is not an object or lacks a string code or sentence is skipped, and a location or suggested fix of another shape is left out of its item. The doc now says exactly which shapes those are. The changelog entry is marked Breaking and says that a server still answering the older verdict shape is no longer read. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01ChCUgUaFZK7FTEAc8uPAVL
lchoquel
added a commit
that referenced
this pull request
Oct 25, 2026
Brings in PR #149, the validate hook bundle re-vendored from @pipelex/sdk 0.53.0. CHANGELOG.md: under [Unreleased] / Changed, kept dev's final wording of the hook's method-tree entry and its new entry on naming each problem item, then this branch's entry on the skills reading problem documents. docs/decisions.md: kept both new 2026-10-24 sections, dev's "The hook names an invalid verdict's problem items" first, then this branch's "The skills read the workshop's problem document". Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01ChCUgUaFZK7FTEAc8uPAVL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation hook now reads a refused method's verdict as the hosted problem document carries it, naming each problem item with its location and suggested fix in the block reason. The bundle is vendored from the SDK branch for now and is re-vendored from the released pipelex-sdk before this merges.
Closes L-261023-f21e88
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uzyvwk5dEQLz1LibAnaoNk
Summary by cubic
Re-vendors the validation hook from
@pipelex/sdk0.50.0 so it reads an invalid verdict'serrors[]as MTHDS problem items instead of the oldervalidation_errors[]. A block reason now names each problem item by its code, sentence, pipe, and file, with its suggested fix beneath it, without relying on the server's Markdown.Bug Fixes
Migration
validation_errors[]) is no longer read, so its problems are no longer reported.Written for commit f2278c6. Summary will update on new commits.