chore(ci): use unified ci-rwo storage class and add storage-class policy check - #4867
Conversation
…icy check Replace all hyperdisk-rwo references with the cluster-agnostic ci-rwo storage class, which is provisioned per cluster by PingCAP-QE/ee-ops (GCP: hyperdisk-balanced; TencentCloud: CBS HSSD). Add .ci/verify-storage-class-policy.sh with a whitelist (.ci/storage-class-policy-allowlist.txt) and wire it as the pull-verify-storage-class-policy presubmit to prevent storage class name drift across clusters.
|
@wuhuizuo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 participant
What
hyperdisk-rworeferences (508 files, 793 occurrences) with the cluster-agnosticci-rwostorage class name, across Jenkins pipelines (pipelines/,jobs/), Prow jobs (prow-jobs/), and Tekton templates (tekton/)..ci/verify-storage-class-policy.sh+.ci/storage-class-policy-allowlist.txtthat fail when a manifest references a storage class outside the allowlist (ci-rwo, plus legacyceph-blockused by tekton/v0 on the prod rook-ceph cluster;${STORAGE_CLASSNAME_*}env indirections in tekton/v1 are always allowed).pull-verify-storage-class-policyinprow-jobs/pingcap-qe/ci/presubmits.yaml.Why
Storage class names are cluster-specific (fresh GKE clusters ship
standard-rwo/standard/premium-rwo/dynamic-rwobut nothyperdisk-rwo), so hardcoding cluster-specific names makes CI configs fail on new clusters.ci-rwois a unified name provisioned per cluster by PingCAP-QE/ee-ops (see ee-ops PR #2172), letting CI configs stay cluster-agnostic.Note
This is a rename-only change; the
ci-rwoStorageClass (hyperdisk-balanced, 10000 IOPS / 400Mi) has already been created in the prow cluster, so jobs keep working after merge.Related
ci-rwostorage class for gcp and tencentcloud