Repository navigation
wpfacts: the key-sign unit test for an integer past int32 uses two callers - #14465
Merged
Merged
Conversation
… (one caller gives the exact value 3)
Pre-merge checks:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. | |
| Description check | |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14458.
tests::key_signs::a_key_that_is_no_int32_has_no_signfailed on main: itsK[i >>> 0]case had one caller,f(3), so the facts gave the exact key[3,3], an int32. Withf(3) + f(-1)the hull is[3, 4294967295], past int32, and the site has no key sign, which is what the test is about.Test only; no compiler change.
cargo test -p perry-wpfacts --lib key_signs: 5 passed (macOS, debug). Codegenindex_key(15 tests, with the three key-sign tests) passed on qb10 on c8adb42.