ci(release): publish stable releases instead of pre-releases - #50
Merged
Conversation
Notarization needs a paid Developer ID and is not planned, so waiting for it before calling a release stable means waiting forever. The builds are tested and shipped; ad-hoc signing is a distribution constraint, not a quality one. This also unblocks the direct download link: /releases/latest/download/ skips pre-releases, which is the only reason the site pointed at the Releases page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release so far has been marked
--prerelease, waiting on notarization that needs a paid Apple Developer ID and is not planned. That is an indefinite wait for a label.The builds are linted, tested and packaged by CI. Ad-hoc signing is a distribution constraint, not a quality one, and marking them provisional forever helps nobody.
What it unblocks
https://github.com/Periicles/Notchapp/releases/latest/download/NotchBar.dmgskips pre-releases — that, not notarization, is the only reason the landing page pointed at the Releases listing instead of offering a one-click download. Dropping the flag makes the direct link work.The commented notarization hooks stay in the workflow, reframed as "not planned" rather than pending, since they are still accurate should a Developer ID ever exist.
Docs follow in a separate PR; the existing v0.3.0 release is flipped to stable by hand so the link resolves today.