Connected to frontend with e2e testing on create member and sign up form - #60
Open
Allimonae wants to merge 1 commit into
Open
Connected to frontend with e2e testing on create member and sign up form#60Allimonae wants to merge 1 commit into
Allimonae wants to merge 1 commit into
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Allimonae
force-pushed
the
create-member-connect
branch
3 times, most recently
from
July 21, 2026 17:16
078696f to
c3deb0a
Compare
Allimonae
force-pushed
the
create-member-connect
branch
from
July 24, 2026 17:10
c3deb0a to
d3b485e
Compare
|
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/24/26)2 reviewers were added to this PR based on Henry Chen's automation. |
spiffyy99
reviewed
Jul 26, 2026
| .build(); | ||
| Member updatedMember = memberRepo | ||
| .updateMember(member) | ||
| .orElseThrow(() -> new ResponseStatusException(HttpStatus.NOT_FOUND, "Member not found")); |
There was a problem hiding this comment.
nit - should probably be MemberNotFoundException for consistency. it will ultimately end up being a 404 anyway
There was a problem hiding this comment.
(i know this isnt part of the PR but might as well fix it here 🙃
spiffyy99
reviewed
Jul 26, 2026
| // TODO: Implement test cases for MemberService methods after createMember | ||
|
|
||
| // @Test | ||
| // void testUpdateMember() { |
There was a problem hiding this comment.
i guess we'll be adding these in another PR? is updateMember not fully functional yet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchingPreftomatchPrefacross the frontend/api/membersendpointWhat changed?
matchingPreftomatchPrefin theMemberProfileValuesinterface, Zod schema, and all related form field bindings and handlers inSignUpForm.tsx.matchingPrefOptionsvariable tomatchingPreferenceOptionsfor clarity.Promise.resolve()stub inSignUpForm's submit handler with a realPOST /api/membersfetch call. On success, the form is reset; on failure, an error message from the API response (or a fallback) is displayed; on network error, a connection-specific message is shown.MemberControllerTestcovering successful member creation, validation rejection on blankfullName, and conflict response on duplicate email.MemberServiceTestcovering successful member creation with all fields and duplicate email detection (verifyingcreateMemberon the repo is never called in that case).How to test?
/api/members, resets on success, and displays appropriate error messages on failure or network issues.MemberControllerTestandMemberServiceTestand confirm all tests pass.Why make this change?
The
matchingPreffield name was inconsistent with the backend'smatchPrefnaming convention, causing a mismatch between the frontend payload and the API contract. The form also lacked a real API integration, relying on a placeholder stub that never actually persisted data. Tests were added to establish baseline coverage for the member creation flow.