Implement trigger config matching and FieryImpactHeistMaceImplicit, TriggeredMoltenStrike skills#9953
Merged
LocalIdentity merged 4 commits intoJul 20, 2026
Conversation
FieryImpactHeistMaceImplicit and TriggeredMoltenStrike Signed-off-by: Paliak <[email protected]>
Signed-off-by: Paliak <[email protected]>
Signed-off-by: Paliak <[email protected]>
Contributor
Author
|
No idea why |
LocalIdentity
approved these changes
Jul 20, 2026
LocalIdentity
merged commit Jul 20, 2026
eefe1fd
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Implements ability to match a trigger config by skillId. This is generally a preferred approach if the skills is a "triggered" variant as it prevents accidental application of trigger logic to "normal" skills
Adds a basic test for the trigger config by skillId matching.
The added line in ModParser could be merged into other simillar ones but i left it as is for readability as that block is complicated enough as is.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
n/a
After screenshot: