Add Manage Loadouts view and version-prefix-tolerant matching#9945
Open
Coolgatty wants to merge 1 commit into
Open
Add Manage Loadouts view and version-prefix-tolerant matching#9945Coolgatty wants to merge 1 commit into
Coolgatty wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Referenced Issues: #9451
Two related loadout pain points:
[version]prefix (e.g.[3.28 (alternate)]). That prefix was compared against the plainly-named item/skill/config sets, so the loadout no longer grouped and dropped out of the loadouts dropdown.This PR:
Manage Loadouts... (ctrl-l)option to the loadouts dropdown that opens a management popup mirroring the Manage Passive Trees view. From it you can New / Rename / Copy / Delete and drag-reorder a loadout as a whole, so its tree, item, skill and config sets are created/renamed/copied/deleted/reordered together.New Loadoutdropdown entry into the Manage view's New button.[version]display prefix), so a loadout whose tree is on a non-latest version still groups with its plainly-named sets.Steps taken to verify a working solution:
Manage Loadouts...(and viaCtrl+L); created, renamed, copied, deleted and drag-reordered loadouts, and confirmed the tree / item / skill / config sets in each tab all changed together.spec/System/TestManageLoadouts_spec.lua) covering version-prefix-tolerant matching, whole-loadout delete, and whole-loadout reorder.Link to a build that showcases this PR:
N/A — reproducible on any build with multiple loadouts.
Before screenshot:
After screenshot: