Skip to content

render ascendancy flavor text only at higher zoom levels#9944

Open
JustinStitt wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
JustinStitt:ascendancy-flav-text-zoom
Open

render ascendancy flavor text only at higher zoom levels#9944
JustinStitt wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
JustinStitt:ascendancy-flav-text-zoom

Conversation

@JustinStitt

Copy link
Copy Markdown
Contributor

let's only render ascendancy flavor text when we are actually zoomed in enough to read it.

also, dim unselected ascendancy flavor text at a clip of 50% (to match the existing background dimming).

Description of the problem being solved:

When zoomed out, many ascendancy flavor texts bleed out from its portrait. Fix this by hiding flavor text until an appropriate zoom level is reached.

While we're here, let's also dim any unselected ascendancy's flavor text at a clip of 50% (matching existing background art dimming).

Steps taken to verify a working solution:

  • Visually inspect flavor text at various zoom levels
  • Select/Deselect ascendancy to see flavor text dimming

Link to a build that showcases this PR:

N/A, empty build will suffice.

Images

Before/After Images

Before screenshot:

When zoomed out, we see bleeding text which looks unprofessional. You can't read this text anyways.

image

notice the text clipping out

After screenshot:

Hide the flavor text when zoomed out.

image

notice no text

Before/After Images (text dimming) image

notice both the selected and unselected ascendancy have the same text style

After Screenshot (text dimming on unselected)

image

As you can see, it is now much more obvious which ascendancy is selected and we have a more coherent design language by dimming unselected ascendancy's background and flavour text.

A GIF showing the new look, text disappears at low zoom levels, unselected ascendancy flav. text is dim

variants

let's only render ascendancy flavor text when we are actually zoomed in
enough to read it.

also, dim unselected ascendancy flavor text at a clip of 50% (to match
the existing background dimming).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant