render ascendancy flavor text only at higher zoom levels#9944
Open
JustinStitt wants to merge 1 commit into
Open
render ascendancy flavor text only at higher zoom levels#9944JustinStitt wants to merge 1 commit into
JustinStitt wants to merge 1 commit into
Conversation
let's only render ascendancy flavor text when we are actually zoomed in enough to read it. also, dim unselected ascendancy flavor text at a clip of 50% (to match the existing background dimming).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let's only render ascendancy flavor text when we are actually zoomed in enough to read it.
also, dim unselected ascendancy flavor text at a clip of 50% (to match the existing background dimming).
Description of the problem being solved:
When zoomed out, many ascendancy flavor texts bleed out from its portrait. Fix this by hiding flavor text until an appropriate zoom level is reached.
While we're here, let's also dim any unselected ascendancy's flavor text at a clip of 50% (matching existing background art dimming).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A, empty build will suffice.
Images
Before/After Images
Before screenshot:
When zoomed out, we see bleeding text which looks unprofessional. You can't read this text anyways.
notice the text clipping out
After screenshot:
Hide the flavor text when zoomed out.
notice no text
Before/After Images (text dimming)
notice both the selected and unselected ascendancy have the same text style
After Screenshot (text dimming on unselected)
As you can see, it is now much more obvious which ascendancy is selected and we have a more coherent design language by dimming unselected ascendancy's background and flavour text.
A GIF showing the new look, text disappears at low zoom levels, unselected ascendancy flav. text is dim