Skip to content

Add support for Bifurcated Crits#9940

Merged
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
vaisest:bifurcate
Jul 20, 2026
Merged

Add support for Bifurcated Crits#9940
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
vaisest:bifurcate

Conversation

@vaisest

@vaisest vaisest commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Ports over bifurcate code from pob2 for:

The Mystical Infusion Notable Passive Skill no longer grants Base Spell Critical Strike Chance of Spells is equal to that of Main Hand Weapon. It now grants Spell Critical Strike Chance Bifurcates, and 30% less Spell Critical Strike Chance.
Bifurcated Critical Strikes cause Critical Strike chance to be rolled twice when determining if a Critical Strike should occur:

  • If either roll succeeds the hit will be a regular Critical Strike, and if both rolls succeed the amount of extra damage dealt by the critical strike will be doubled. This is equivalent to doubling the amount by which the Critical Strike Multiplier exceeds 100 for that Hit.
  • If a modifier makes your Critical Strike Chance Lucky or Unlucky, that luck will apply individually to each of the critical strike chance rolls.
  • Effects which cause Hits to Always be Critical Strikes prevent Bifurcation - those hits do not roll the chance, so cannot roll it twice.

Steps taken to verify a working solution:

  • Test ported
  • More tests added
  • Only affects spells
  • Result seems correct
  • Crit damage bonus disabled with guaranteed crit
  • Does not apply to perfect agony (it sets NoCritMultiplier and the whole crit calculation gets skipped)

Link to a build that showcases this PR:

See test

Before screenshot:

After screenshot:

Path{space}of{space}Building_2026-07-19_10-53-03 image image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jul 20, 2026
@LocalIdentity
LocalIdentity merged commit 03ae462 into PathOfBuildingCommunity:dev Jul 20, 2026
2 of 3 checks passed
@LocalIdentity LocalIdentity changed the title Port support for spell bifurcated crits Add support for Bifurcated Crits Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants