Add support for sorting my Minion specific stats#9930
Merged
Conversation
vaisest
changed the title
vaisest
commented
Jul 5, 2026
| end | ||
|
|
||
| -- these stats don't exist on minions or generally don't exist on both player and minion | ||
| local minionNonApplicableStats = { |
Contributor
Author
There was a problem hiding this comment.
I should've asked this in the pob2 PR already, but I'm not sure if this filters out enough stats. I'm not exactly sure what stats minions can actually have
Some of the stats like EHP seem to be calculated even though they aren't displayed in the client
Fixes the implementaiton of lower is better stats and cleans up it's usage Fixes the unique list not using the minion stat sorting correctly
LocalIdentity
approved these changes
Jul 20, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
Fixed some issues with the unique list and the lower is better sorting but now looks good
LocalIdentity
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2026, fixes #4522, fixes #1335, fixes #7205
Description of the problem being solved:
Ports PathOfBuildingCommunity/PathOfBuilding-PoE2#2261
Fixes #8096 by rewriting the power gain calculations in timeless jewel calc code
Steps taken to verify a working solution:
Not sure if militant faith works properly as I have no idea how to use the item
Link to a build that showcases this PR:
Before screenshot:
After screenshot: