Repository navigation
Conversation
…work to be done in this regard
…o types and prices
… to stop after a stop event
…ires some testing
bogadisa
commented
Oct 3, 2026
| id=self.id, note=self.note, category=detector.get_category(self) | ||
| ) | ||
|
|
||
| def __eq__(self, other: CacheItem | object) -> bool: |
bogadisa
commented
Oct 3, 2026
| incoming_data = list[tuple[int, int, float, int, bool]]() | ||
| for item in updated_availability: | ||
| item_id = incoming_to_database.get((item.gameItemId, item.leagueId)) | ||
| if item_id is None: |
Collaborator
Author
There was a problem hiding this comment.
should this raise an error?
bogadisa
commented
Oct 3, 2026
| rolls = list[ItemModifierRoll]() | ||
| for roll in match.groups(): | ||
| try: | ||
| if roll in ["reduced", "increased"]: |
Collaborator
Author
There was a problem hiding this comment.
should this multiply some number by -1 if it is reduced?
bogadisa
commented
Oct 3, 2026
| rolls.append(ItemModifierRoll(position=position, roll=extracted_roll)) | ||
| position += 1 | ||
| except: | ||
| print(roll, position, db_mod) |
Collaborator
Author
There was a problem hiding this comment.
remove before merging
bogadisa
commented
Oct 3, 2026
| pass | ||
| # Properties to receive on modifier creation | ||
| class ModifierCreate(ModifierBase): | ||
| rolls: list[ModifierRoll] = _pydantic.Field(default_factory=list) |
Collaborator
Author
There was a problem hiding this comment.
Does this need a default factory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.