Stop libpar2.h leaking config.h, _OPENMP and internal macros - #312
Open
mnightingale wants to merge 4 commits into
Open
Stop libpar2.h leaking config.h, _OPENMP and internal macros#312mnightingale wants to merge 4 commits into
mnightingale wants to merge 4 commits into
Conversation
…ic API does not depend on _OPENMP
mnightingale
force-pushed
the
pr/public-header
branch
from
September 5, 2026 15:52
fb7dccd to
22e0e29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpar2.hcannot currently be included from outside the build tree: it includesconfig.h, and thepar2create/par2repairsignatures change shape under#ifdef _OPENMP, so a consumer built without OpenMP does not match a library built with it. It also definesstricmp,PATHSEPand_FILE_THREADSinto the including translation unit.The integer types now come from
<cstdint>, the entry points always take the thread counts, and the macros move to the private header. No behaviour change.