Add opt-in for full file hash verification - #310
Open
mnightingale wants to merge 3 commits into
Open
Conversation
mnightingale
force-pushed
the
feature/full-file-hash
branch
from
September 5, 2026 15:52
8bc21ab to
7260347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default verification behaviour makes better use of multithreading by processing blocks independently, because if every block matches and the file is the right length then the hash of the whole file cannot differ.
For those that prefer as close to absolute certainty as is possible this adds an opt-in flag to also check the full file hash.
The obvious way to implement this would be to turn off the aligned block scan, but that gives up the block threading and is much slower.
The style of this flag is different to the others, but it was as suggested and frankly the single character flags are rather confusing.