Repository navigation
key_store_file: accept signature type 0 in key store headers - #88
Merged
cwerling merged 1 commit intoOct 2, 2026
Merged
Conversation
Key stores in early ThinkPad T14/X13 Gen 1 AMD (Renoir) releases have no $PS1 magic and a signature type of 0 at 0x34, next to a 0x200 byte signature that verifies against the certifying key. The header check required 2 there and the resulting AssertionError aborted the whole ROM. Name the two dwords at 0x30 and 0x34 as in HeaderFile (signed flag and signature type) and accept signature type 0 or 2. The signature size is still derived from the header sizes, so it stays 0x200 for these key stores. Signed-off-by: iwanicki92 <[email protected]>
Member
|
Reopening to retrigger CI with the updated workflow (actions/checkout pwn-request fix). |
Metrics
|
| Metric | Value |
|---|---|
| Files Processed | 68 |
| Stdout Lines | 14,965 |
| Stderr Lines | 164 |
| Total Lines | 15,129 |
| Error Ratio | 1.08% |
PSPTool python library metrics
| Status | Count | Percentage |
|---|---|---|
| ✓ Successful | 68 | 100.0% |
| ✗ Failed | 0 | 0.0% |
| Total | 68 | 100% |
All files parsed successfully!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key stores in early ThinkPad T14/X13 Gen 1 AMD (Renoir) releases have no
$PS1magic and a signature type of 0 at0x34, next to a0x200byte signature that verifies against the certifying key. The header check required 2 there and the resultingAssertionErroraborted the whole ROM.Name the two dwords at
0x30and0x34as inHeaderFile(signed flag and signature type) and accept signature type 0 or 2. The signature size is still derived from the header sizes, so it stays0x200for these key stores.