Repository navigation
DEV: expose current program application in detail - #731
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
База
63ebc4accdb147cf1e02feaaf141d79e7d92966b(origin/devпослеgit fetch origin).Зачем
Angular PR #339 должен различать состояния «Создать заявку» и «Перейти в заявку». Восстановление заявки через
GET /auth/users/projects/ненадежно: legacy serializers возвращают одну singular-связьpartner_program, хотя одинProjectможет быть связан с несколькими программами черезPartnerProgramProject. Из-за этого для программы B могла выбираться более ранняя связь программы A.Что изменено
GET /programs/<id>/добавлено стабильное top-level полеcurrent_application.null.{ "current_application": { "project_id": 123, "program_link_id": 700, "submitted": false } }partner_program_id=<current program>иproject__leader_id=<current user>.Project; collaborator чужого проекта не получает эту заявку.submittedберется напрямую изPartnerProgramProject.submitted.PartnerProgramProject.pk.current_application: null; lookup заявки для них не выполняется..values(...).first(), без pagination scan и N+1.POST /programs/<id>/projects/apply/не изменялся.Regression-тесты
Добавлены сценарии:
null;null;null;submitted: false;submitted: true;MultipleObjectsReturned.Проверки
Локально выполнены:
git diff --check;origin/devподтвержден как63ebc4accdb147cf1e02feaaf141d79e7d92966b.Локально не выполнены и оставлены для CI:
Причина: в локальном окружении нет установленных backend dependencies, доступ к package index недоступен, а Docker daemon недоступен. Dependency-файлы и Docker/workflows намеренно не менялись.