Trying jax for gradients - #24
Merged
Merged
Conversation
jmlarson1
marked this pull request as ready for review
October 29, 2025 18:18
mmenickelly
approved these changes
Aug 17, 2026
mmenickelly
left a comment
mmenickelly
left a comment
Collaborator
There was a problem hiding this comment.
I appreciate the test, it runs locally and confirms that there is no significant difference in the Jax and numpy output. I would leave that test in here for now in case we suspect weird things on a new environment.
Otherwise, this is all a good idea in principle and it works for this limited dataset, so it's an acceptable PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our python gradients/jacobians were computed in matlab by AdiMAT and then translated to python.
We can also compute them using Jax. This allows us to easily compute Hessians (if desired).